Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataObject usage from OpenDialogUrl provider #1712

Closed
sivaschenko opened this issue Aug 4, 2020 · 1 comment · Fixed by magento/magento2#29491
Closed

Remove DataObject usage from OpenDialogUrl provider #1712

sivaschenko opened this issue Aug 4, 2020 · 1 comment · Fixed by magento/magento2#29491
Assignees
@joweecaquicla
Labels
Backend Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Aug 4, 2020 •
edited
Loading

  • Remove constructor of Magento\Ui\Component\Form\Element\DataType\Media\OpenDialogUrl
  • Remove corresponding configuration from app/code/Magento/MediaGalleryIntegration/etc/adminhtml/di.xml
  • Replace Magento\MediaGalleryIntegration\Model\OpenDialogUrlProvider with Magento\MediaGalleryIntegration\Plugin\NewMediaGalleryOpenDialogUrl after plugin

Requires discussion before implementation
@sivaschenko sivaschenko added Backend Priority: P3 May be fixed according to the position in the backlog labels Aug 4, 2020
@sivaschenko sivaschenko added this to the 2.1.0 milestone Aug 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 4, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround label Aug 5, 2020
@sivaschenko sivaschenko changed the title Introduce a fixed interface OpenDialogUrl url argument Remove DataObject usage from OpenDialogUrl provider Aug 10, 2020
@sivaschenko sivaschenko added the Progress: good first issue Good for newcomers label Aug 10, 2020
@joweecaquicla joweecaquicla self-assigned this Aug 10, 2020
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 12, 2020
magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
68b35c5 
…enDialogUrl provider - remove data object usage from OpenDialogUrl provider, added new plugin and modified the integration test
@joweecaquicla joweecaquicla mentioned this issue Aug 12, 2020
Merged
4 tasks
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 12, 2020
magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
7f115fd 
…enDialogUrl provider - remove logs
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 12, 2020
magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
0192ca5 
…enDialogUrl provider - fixed static test fails and removed unused class
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 13, 2020
magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
e2f2805 
…enDialogUrl provider - apply requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
Backend Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

#1712: Remove DataObject usage from OpenDialogUrl provider joweecaquicla/magento2
2 participants
@sivaschenko @joweecaquicla