Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1712: Remove DataObject usage from OpenDialogUrl provider #29491

Merged
merged 5 commits into from
Aug 19, 2020
Merged

#1712: Remove DataObject usage from OpenDialogUrl provider #29491

merged 5 commits into from
Aug 19, 2020

Conversation

joweecaquicla
Copy link

@joweecaquicla joweecaquicla commented Aug 12, 2020 •
edited by sivaschenko
Loading

Description (*)

This PR will remove DataObject usage from OpenDialogUrl provide, add new plugin and modified the integration test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Remove DataObject usage from OpenDialogUrl provider adobe-stock-integration#1712: Remove DataObject usage from OpenDialogUrl provider

Manual testing scenarios (*)

Should be tested opening media gallery from wysiwyg, image-uploader (i.e. category image) and page builder
Should be tested for both old and new media gallery

  1. Open Media Gallery - the corresponding media gallery is loaded (old or new depending on the configuration)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
68b35c5 
…enDialogUrl provider - remove data object usage from OpenDialogUrl provider, added new plugin and modified the integration test
@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run all tests

magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
0192ca5 
…enDialogUrl provider - fixed static test fails and removed unused class
@joweecaquicla
Copy link
Author

@magento run all tests

@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 13, 2020
sivaschenko
sivaschenko requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @joweecaquicla ! Please see my comments

app/code/Magento/Ui/Component/Form/Element/DataType/Media/OpenDialogUrl.php Outdated
@@ -38,7 +28,7 @@ public function __construct(DataObject $url = null)
public function get(): string
{
if ($this->openDialogUrl) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the constructor for ability to initialize openDialogUrl property

app/code/Magento/MediaGalleryIntegration/composer.json
@@ -6,7 +6,8 @@
"magento/framework": "*",
"magento/module-media-gallery-ui-api": "*",
"magento/module-media-gallery-api": "*",
"magento/module-media-gallery-synchronization-api": "*"
"magento/module-media-gallery-synchronization-api": "*",
"magento/module-ui": "*"
Copy link
Member

@sivaschenko sivaschenko Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a pull request to https://github.com/magento/partners-magento2-infrastructure with an update to composer etalon (see https://github.com/magento/partners-magento2-infrastructure/pull/19 for example) and cross reference the pull requests as related in the description

@ghost ghost assigned sivaschenko Aug 13, 2020
magento/adobe-stock-integration#1712: Remove DataObject usage from Op…
e2f2805 
…enDialogUrl provider - apply requested changes
@ghost ghost removed the Progress: needs update label Aug 14, 2020
@sivaschenko
Copy link
Member

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8010 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 14, 2020
@engcom-Lima
Copy link
Contributor

✔️ QA Passed
If Enhanced Media Gallery disabled:
Screenshot_105
If Enhanced Media Gallery enabled:
Screenshot_106
All cases are manually covered

@engcom-Lima engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 17, 2020
@sivaschenko
Copy link
Member

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Aug 19, 2020
@gabrieldagama
ENGCOM-8010: #1712: Remove DataObject usage from OpenDialogUrl provider
a528201 
#29491
@magento-engcom-team magento-engcom-team merged commit 03e28d1 into magento:2.4-develop Aug 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov added this to the 2.4.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryIntegration Component: Ui Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Remove DataObject usage from OpenDialogUrl provider
5 participants
@joweecaquicla @sivaschenko @magento-engcom-team @engcom-Lima @sidolov