Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1589: Hitting Enter key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image #1597

Merged
merged 3 commits into from
Jul 17, 2020
Merged

#1589: Hitting Enter key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
089fb2b
magento/adobe-stock-integration#1589: Hitting Enter key on Edit Image…
yolouiese Jul 14, 2020
5fa5876
magento/adobe-stock-integration#1589: Hitting Enter key on Edit Image…
yolouiese Jul 15, 2020
88a31c9
magento/adobe-stock-integration#1589: Hitting Enter key on Edit Image…
yolouiese Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ define([
'jquery',
'underscore',
'uiComponent',
'Magento_Ui/js/lib/key-codes',
'Magento_MediaGalleryUi/js/action/getDetails'
], function ($, _, Component, getDetails) {
], function ($, _, Component, keyCodes, getDetails) {
'use strict';

return Component.extend({
Expand Down Expand Up @@ -100,6 +101,25 @@ define([
addMediaGridMessage: function (code, message) {
this.mediaGridMessages().add(code, message);
this.mediaGridMessages().scheduleCleanup();
},

/**
* Handle Enter key event to save image details
*
* @param {Object} data
* @param {jQuery.Event} event
* @returns {Boolean}
*/
handleEnterKey: function (data, event) {
gabrieldagama marked this conversation as resolved.
Show resolved Hide resolved
var modalElement = $(this.modalSelector),
key = keyCodes[event.keyCode];

if (key === 'enterKey') {
event.preventDefault();
modalElement.find('.page-action-buttons button.save').click();
}

return true;
}
});
});
5 changes: 3 additions & 2 deletions MediaGalleryUi/view/adminhtml/web/template/image/image-edit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
</label>
<div class="admin__field-control">
<input type="text" id="title" data-ui-id="title" name="title" placeholder="Title"
class="admin__control-text required-entry minimum-length-1 maximum-length-120" data-bind="value: image().title"
class="admin__control-text required-entry minimum-length-1 maximum-length-120"
data-bind="value: image().title, event: {keypress: handleEnterKey}"
data-validate="{'required':true,'validate-alphanum-with-spaces':true, 'validate-length':true}"/>
</div>
</div>
Expand All @@ -36,7 +37,7 @@
name="description"
class="admin__control-textarea minimum-length-0 maximum-length-500"
rows="7" cols="80"
data-bind="value: image().description"
data-bind="value: image().description, event: {keypress: handleEnterKey}"
data-validate="{'validate-alphanum-with-spaces':true, 'validate-length':true}"></textarea>
</div>
</div>
Expand Down