#1589: Hitting Enter key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Magento Dashboard instead of Saving the image - prevented page to reload and image details are saved when hitting enter
|
@magento run all tests |
gabrieldagama
suggested changes
Jul 15, 2020
There was a problem hiding this comment.
Hi @yolouiese, thanks for the PR, it looks great! Please follow below a comment:
… to Magento Dashboard instead of Saving the image - added key codes library and revised key code condition
|
@magento run all tests |
gabrieldagama
previously approved these changes
Jul 16, 2020
… to Magento Dashboard instead of Saving the image - fixed the error in static test invalid case of type of booelean
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
gabrieldagama
approved these changes
Jul 16, 2020
m2-community-project
bot
added
Progress: acceptance testing
and removed
Progress: changes requested
labels
|
✔️ QA PAssed
|
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: acceptance testing
labels
|
Hi @yolouiese, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to verify (*)
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)