Skip to content

Commit

Permalink
Merge pull request #1597 from yolouiese/1589-hitting-enter-on-edit-im…
Browse files Browse the repository at this point in the history
…age-redirects-to-dashboard

#1589: Hitting Enter key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image
  • Loading branch information
Gabriel da Gama authored Jul 17, 2020
2 parents 30384b2 + 88a31c9 commit 094e513
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 3 deletions.
22 changes: 21 additions & 1 deletion MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ define([
'jquery',
'underscore',
'uiComponent',
'Magento_Ui/js/lib/key-codes',
'Magento_MediaGalleryUi/js/action/getDetails'
], function ($, _, Component, getDetails) {
], function ($, _, Component, keyCodes, getDetails) {
'use strict';

return Component.extend({
Expand Down Expand Up @@ -100,6 +101,25 @@ define([
addMediaGridMessage: function (code, message) {
this.mediaGridMessages().add(code, message);
this.mediaGridMessages().scheduleCleanup();
},

/**
* Handle Enter key event to save image details
*
* @param {Object} data
* @param {jQuery.Event} event
* @returns {Boolean}
*/
handleEnterKey: function (data, event) {
var modalElement = $(this.modalSelector),
key = keyCodes[event.keyCode];

if (key === 'enterKey') {
event.preventDefault();
modalElement.find('.page-action-buttons button.save').click();
}

return true;
}
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
</label>
<div class="admin__field-control">
<input type="text" id="title" data-ui-id="title" name="title" placeholder="Title"
class="admin__control-text required-entry minimum-length-1 maximum-length-120" data-bind="value: image().title"
class="admin__control-text required-entry minimum-length-1 maximum-length-120"
data-bind="value: image().title, event: {keypress: handleEnterKey}"
data-validate="{'required':true,'validate-alphanum-with-spaces':true, 'validate-length':true}"/>
</div>
</div>
Expand All @@ -36,7 +37,7 @@
name="description"
class="admin__control-textarea minimum-length-0 maximum-length-500"
rows="7" cols="80"
data-bind="value: image().description"
data-bind="value: image().description, event: {keypress: handleEnterKey}"
data-validate="{'validate-alphanum-with-spaces':true, 'validate-length':true}"></textarea>
</div>
</div>
Expand Down

0 comments on commit 094e513

Please sign in to comment.