Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting "Enter" key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image #1589

Closed
chalov-anton opened this issue Jul 9, 2020 · 2 comments · Fixed by #1597
Closed

Hitting "Enter" key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image #1589

chalov-anton opened this issue Jul 9, 2020 · 2 comments · Fixed by #1597
Assignees
@yolouiese
Labels
bug Something isn't working Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Milestone
2.1.0

Comments

@chalov-anton
Copy link
Contributor

Precondition (*)

  1. Install Magento with Adobe Stock Integration
  2. Enhanced Media Gallery is Enabled
  3. A saved image Preview from Adobe Stock

Steps to reproduce (*)

  1. Go to Content - Media Gallery
  2. Select an image saved from Adobe Stock and click "three dots" in the bottom right
  3. Select Edit
  4. Place the cursor into Name field
  5. Type any text
  6. Hit Enter key from your keyboard

Expected result (*)

The Edit Image window is closed, the file name is saved

Actual result (*)

User is redirected to Magento Dashboard, the file name is not saved
Peek 2020-07-09 17-04
@chalov-anton chalov-anton added bug Something isn't working Severity: S4 A minor problem, annoyance, or technical issue with minimal impact labels Jul 9, 2020
@chalov-anton chalov-anton added this to the 2.1.0 milestone Jul 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 9, 2020

Hi @chalov-anton. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@yolouiese
Copy link
Contributor

@magento I am working on this

yolouiese added a commit to yolouiese/adobe-stock-integration that referenced this issue Jul 14, 2020
@yolouiese
magento#1589: Hitting Enter key on Edit Image page redirects the user…
089fb2b 
… to Magento Dashboard instead of Saving the image - prevented page to reload and image details are saved when hitting enter
@yolouiese yolouiese mentioned this issue Jul 14, 2020
Merged
yolouiese added a commit to yolouiese/adobe-stock-integration that referenced this issue Jul 15, 2020
@yolouiese
magento#1589: Hitting Enter key on Edit Image page redirects the user…
5fa5876 
… to Magento Dashboard instead of Saving the image - added key codes library and revised key code condition
yolouiese added a commit to yolouiese/adobe-stock-integration that referenced this issue Jul 16, 2020
@yolouiese
magento#1589: Hitting Enter key on Edit Image page redirects the user…
88a31c9 
… to Magento Dashboard instead of Saving the image - fixed the error in static test invalid case of type of booelean
gabrieldagama pushed a commit that referenced this issue Jul 17, 2020
Merge pull request #1597 from yolouiese/1589-hitting-enter-on-edit-im…
094e513 
…age-redirects-to-dashboard

#1589: Hitting Enter key on Edit Image page redirects the user to Magento Dashboard instead of Saving the image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yolouiese yolouiese

Labels
bug Something isn't working Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Projects
None yet
Milestone
2.1.0
2 participants
@yolouiese @chalov-anton