Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Schema inconsistency of "Quantity / Qty" declaration #631

Closed
naydav opened this issue Apr 24, 2019 · 1 comment
Closed

Schema inconsistency of "Quantity / Qty" declaration #631

naydav opened this issue Apr 24, 2019 · 1 comment
Assignees
@osrecio
Labels
bug Something isn't working Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Apr 24, 2019

In some places qty is used (CartItemInput and CartItemInterface), and in other places it is expanded to the full word quantity (CartItemQuantityInput and CartItemQuantity).

  1. qty should be renamed quantity
  2. Input CartItemQuantityInput should be renamed to CartItemUpdateQuantityInput
  3. Input CartItemInput should be renamed to CartItemQuantityInput
  4. data: CartItemInput! should be renamed to quantity: CartItemQuantityInput!
@naydav naydav added bug Something isn't working good first issue Good for newcomers Contribution Day Tickets is good for start on Contribution Day Component: QuoteGraphQl labels Apr 24, 2019
@osrecio osrecio self-assigned this Apr 25, 2019
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 25, 2019
@osrecio
magento#631 Rename qty by quantity
83262c0
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 25, 2019
@osrecio
magento#631 Rename CartItemQuantityInput by CartItemUpdateQuantityInput
67c4686
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 25, 2019
@osrecio
magento#631 Rename CartItemInput by CartItemQuantityInput
4701581
@osrecio osrecio mentioned this issue Apr 25, 2019
Merged
4 tasks
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 26, 2019
@osrecio
magento#631 Fix Fail tests
dd09a52
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 26, 2019
@osrecio
magento#631 Fix Fail tests with qty error
1d8a7ee
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 26, 2019
@osrecio
magento#631 Fix Fail tests with qty error api functional tests
a146f8d
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 26, 2019
@osrecio
magento#631 Fix Fail tests with required field quantity
68aebaa
osrecio added a commit to osrecio/graphql-ce that referenced this issue Apr 29, 2019
@osrecio
magento#631 Rename qty by quantity
e8f1369 
Rename CartItemQuantityInput by CartItemUpdateQuantityInput
Rename CartItemInput by CartItemQuantityInput
Adapt tests
@naydav naydav added this to the Release: 2.3.2 milestone Apr 30, 2019
@naydav
Copy link
Contributor Author

naydav commented Apr 30, 2019

#634

@naydav naydav closed this as completed Apr 30, 2019
magento-engcom-team pushed a commit that referenced this issue Jul 23, 2019
@osrecio @naydav
#631 Rename qty by quantity Rename CartItemQuantityInput by CartItemU…
b35ec00 
…pdateQuantityInput Rename CartItemInput by CartItemQuantityInput Adapt tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@osrecio osrecio

Labels
bug Something isn't working Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @osrecio