Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Fix Quote Schema inconsistency #634

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Apr 25, 2019

Fix Quote Schema inconsistency

Description (*)

  1. qty should be renamed quantity
  2. Input CartItemQuantityInput should be renamed to CartItemUpdateQuantityInput
  3. Input CartItemInput should be renamed to CartItemQuantityInput
  4. data: CartItemInput! should be renamed to quantity: CartItemQuantityInput!

Fixed Issues (if relevant)

  1. Schema inconsistency of "Quantity / Qty" declaration #631: Schema inconsistency of "Quantity / Qty" declaration

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 25, 2019

CLA assistant check
All committers have signed the CLA.

@naydav
Copy link
Contributor

naydav commented Apr 25, 2019

Hello @osrecio,

Thanks for PR, will start a review today! What about another ticket with the scheme fixes? these tickets have top priority due to coming release

@osrecio
Copy link
Member Author

osrecio commented Apr 26, 2019

Hi @naydav , For sure, I want to help in this part.

It's my "first time" with graphql-ce repo and I want to go step by step.

I fixed the tests for this PR, actually I need setup correctly my env to work in right way and be able to launch the tests before creating a PR

@osrecio
Copy link
Member Author

osrecio commented Apr 26, 2019

When the tests stop failing I will squash the commits in one or 2 more descriptive.

This Weekend I will setup my env to run the tests etc before create PR.

@naydav
Copy link
Contributor

naydav commented Apr 26, 2019

When the tests stop failing I will squash the commits in one or 2 more descriptive.

This Weekend I will setup my env to run the tests etc before create PR.

Thanks. Welcome on board. If you will have some questions, please, ping me in the slack channel

Rename CartItemQuantityInput by CartItemUpdateQuantityInput
Rename CartItemInput by CartItemQuantityInput
Adapt tests
@osrecio
Copy link
Member Author

osrecio commented Apr 29, 2019

I ran my own tests and are ok

naydav added a commit that referenced this pull request Apr 29, 2019
@magento-engcom-team magento-engcom-team merged commit 63a740b into magento:2.3-develop Apr 30, 2019
@ghost
Copy link

ghost commented Apr 30, 2019

Hi @osrecio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Documentation updated in magento/devdocs#4502

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants