Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Customer] Improve consistency of country field in customer address #914

Closed
paliarush opened this issue Sep 6, 2019 · 0 comments
Closed

[Customer] Improve consistency of country field in customer address #914

paliarush opened this issue Sep 6, 2019 · 0 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl documentation-completed good first issue Good for newcomers
Milestone
Release: 2.3.4

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 6, 2019 •
edited by melnikovi
Loading

Acceptance criteria:

  • country_id should be deprecated in CustomerAddress and CustomerAddressInput (in the input it should be done via comments since @deprecated directive is only supported for output types)
  • country_code: CountryCodeEnum should be introduced to CustomerAddress and CustomerAddressInput
  • Web API tests should be updated to test both field old and new
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 10, 2019
@melnikovi melnikovi added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
@kisroman kisroman self-assigned this Sep 20, 2019
@kisroman kisroman mentioned this issue Sep 23, 2019
Merged
4 tasks
lenaorobei added a commit to kisroman/graphql-ce that referenced this issue Oct 16, 2019
@lenaorobei
magento#914: [Customer] Improve consistency of country field in custo…
1e5defb 
…mer address
lenaorobei added a commit to kisroman/graphql-ce that referenced this issue Oct 16, 2019
@lenaorobei
magento#914: [Customer] Improve consistency of country field in custo…
21749cc 
…mer address
@lenaorobei lenaorobei mentioned this issue Oct 18, 2019
Closed
@lenaorobei lenaorobei mentioned this issue Nov 4, 2019
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl documentation-completed good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
5 participants
@melnikovi @paliarush @keharper @lenaorobei @kisroman