-
Notifications
You must be signed in to change notification settings - Fork 156
graphQl-914: [Customer] Improve consistency of country field in custo… #958
graphQl-914: [Customer] Improve consistency of country field in custo… #958
Conversation
@@ -28,7 +28,8 @@ input CustomerAddressInput { | |||
city: String @doc(description: "The city or town") | |||
region: CustomerAddressRegionInput @doc(description: "An object containing the region name, region code, and region ID") | |||
postcode: String @doc(description: "The customer's ZIP or postal code") | |||
country_id: CountryCodeEnum @doc(description: "The customer's country") | |||
country_id: CountryCodeEnum @doc(description: "The customer's country") @deprecated(reason: "Use country_code instead.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
country_id: CountryCodeEnum @doc(description: "The customer's country") @deprecated(reason: "Use country_code instead.") | |
country_id: CountryCodeEnum @doc(description: "Deprecated: Use `country_code` instead") |
Input types do not support @deprecated
directive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/CreateCustomerAddressTest.php
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php
Outdated
Show resolved
Hide resolved
app/code/Magento/CustomerGraphQl/Model/Customer/Address/CreateCustomerAddress.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pull latest 2.3-develop
and address found issues. Thank you.
# Conflicts: # app/code/Magento/CustomerGraphQl/etc/schema.graphqls
Hi @lenaorobei, thank you for the review.
|
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerAddressTest.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see minor issues.
Hi @lenaorobei, thank you for the review. |
Hi @kisroman, thank you for your contribution! |
@lenaorobei is it a milestone 2.3.4? |
…mer address
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)