Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin global search - submit by enter doesn't work #10275

Closed
ihor-sviziev opened this issue Jul 18, 2017 · 10 comments
Closed

Admin global search - submit by enter doesn't work #10275

ihor-sviziev opened this issue Jul 18, 2017 · 10 comments
Assignees
@romainruaud
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jul 18, 2017 •
edited
Loading

When I'm trying to submit search form from keyboard - it doesn't work, but if I just click to value in drop-down - it works as expected.

Preconditions

  1. Magento 2.1.7 installed via composer

Steps to reproduce

  1. Go to Magento 2 admin panel
  2. Click "Search" icon in header
  3. Put some query (as example 7029) in search field, wait for autocomplete
  4. Select "<your query>" in Products option with arrow keys on keyboard
  5. Click enter button
    image

Expected result

  1. Browser should be redirected to products grid page with selected query

Actual result

  1. Browser was redirected to the current page with additional get parameter: ?query=#
@AlexWorking
Copy link

Hello, @ihor-sviziev. Based on Your issue an internal ticket was created - MAGETWO-70961. As the issue is fixed You'll be informed. Thank You for reporting.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 24, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 26, 2017
@magento-engcom-team
Copy link
Contributor

@ihor-sviziev, thank you for your report.
We've created internal ticket(s) MAGETWO-70961 to track progress on the issue.

@romainruaud
Copy link
Contributor

I'm working on it #SQUASHTOBERFEST

@okorshenko
Copy link
Contributor

@romainruaud could you please accept the invitation to magento/magento2 on the GitHub?

@romainruaud
Copy link
Contributor

@okorshenko done !

@romainruaud romainruaud mentioned this issue Oct 5, 2017
Merged
4 tasks
@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
magento-team pushed a commit that referenced this issue Oct 26, 2017
@ishakhsuvarov
MAGETWO-81146: Fixing #10275 keyboard submit of adminhtml suggest form.
e7e085c 
#11250

 - Merge Pull Request #11250 from romainruaud/magento2:fix_admin-search-menu
 - Merged commits:
   1. eefdc1c
   2. 00afa44
   3. a0bef71
magento-team pushed a commit that referenced this issue Oct 26, 2017
MAGETWO-81146: Fixing #10275 keyboard submit of adminhtml suggest form.
501b31a 
#11250
magento-team pushed a commit that referenced this issue Oct 26, 2017
@ishakhsuvarov
Merge pull request #1625 from magento-engcom/2.2-develop-prs
04140ba 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82724 Allow coupon code with special charater to be applied to order in checkout #11710
 - MAGETWO-82675 Add a health check to the NGINX configuration sample #11690
 - MAGETWO-82562 Coupon codes not showing in invoice #11635
 - MAGETWO-82535 Fixed ability to set field config from layout xml #11302 [backport 2.2] #11643
 - MAGETWO-81146 Fixing #10275 keyboard submit of adminhtml suggest form. #11250
 - MAGETWO-82761 [Backport 2.2-develop] Dashboard Fix Y Axis for range #11751
 - MAGETWO-82748 Fix Notice: freePackageValue is undefined #11720
 - MAGETWO-82747 [TASK] Updated user.ini according to Magento DevDocs #11734
 - MAGETWO-82537 MAGETWO-81311: Check the length of the array before attempting to sli… #11637
 - MAGETWO-81970 Add missing translations in Magento_UI #11440
 - MAGETWO-81904 FIX #11022 in 2.2-develop: Filter Groups of search criteria parameter have not been included for further processing #11421
 - MAGETWO-82179 Fix Filter Customer Report Review 2.2-develop [Backport] #11522
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81146

@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release soon

@ihor-sviziev ihor-sviziev added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 26, 2017
@magento-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 26, 2018
@shachiarkatkar
Copy link

Is there any way to search complete string instead of each word? For example i want to search customer with full name but i get results based on first name

@ihor-sviziev
Copy link
Contributor Author

@shachiarkatkar AFAIK no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romainruaud romainruaud

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@magento-team @ihor-sviziev @shachiarkatkar @veloraven @okorshenko @romainruaud @AlexWorking @magento-engcom-team