Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET v1/products/attribute-sets/sets/list inconsistent return result #11022

Closed
manhao-chen opened this issue Sep 25, 2017 · 8 comments
Closed

GET v1/products/attribute-sets/sets/list inconsistent return result #11022

manhao-chen opened this issue Sep 25, 2017 · 8 comments
Assignees
@davidverholen
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@manhao-chen
Copy link

manhao-chen commented Sep 25, 2017 •
edited
Loading

Preconditions

currently i'm using the magento 2.1.9 clean fresh install

Steps to reproduce

i call the REST api with the following
http://URL/magento-219/rest/v1/products/attribute-sets/sets/list

Expected result

expect the full list of attribute-sets to be returned

Actual result

{"message":"%fieldName is a required field.","parameters":{"fieldName":"searchCriteria"}}

Steps to reproduce with search fieldname filled in

i call the REST api with the following
http://URL/magento-219/rest/v1/products/attribute-sets/sets/list?searchCriteria[filter_groups][0][filters][0][field]=attribute_set_name&searchCriteria[filter_groups][0][filters][0][condition_type]=eq&searchCriteria[filter_groups][0][filters][0][value]=someAttributeSet

Expected result

expect only someAttributeSet data returned

Actual result

i get the full list of data, it completely disregarded my search query

{"items":[{"attribute_set_id":9,"attribute_set_name":"default2","sort_order":0,"entity_type_id":4},{"attribute_set_id":4,"attribute_set_name":"Default","sort_order":1,"entity_type_id":4}],"search_criteria":{"filter_groups":[{"filters":[{"field":"entity_type_code","value":"catalog_product","condition_type":"eq"}]}]},"total_count":2}
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 25, 2017
@manhao-chen manhao-chen changed the title GET v1/products/attribute-sets/sets/list fieldname is required? GET v1/products/attribute-sets/sets/list inconsistent return result Sep 25, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 26, 2017
@RomanKrut
Copy link

@manhao-chen Hello.
With request like http://URL/magento-219/rest/v1/products/attribute-sets/sets/list you must have some Search Criteria queries to get list of attribute sets, If you want to get only 1 attribute set from GET request use
/V1/products/attribute-sets/{attributeSetId}.
You can get more information here Magento swagger

@manhao-chen
Copy link
Author

I did provide some search criteria, but it appears to completely ignore them and return the full set of attributes-sets

@RomanKrut
Copy link

Yes i think so too , i just try to search like
?searchCriteria[filter_groups][0][filters][0][field]=attribute_set_name&searchCriteria[filter_groups][0][filters][0][value]=123
but my response filter is always "filters":[
{
"field": "entity_type_code",
"value": "catalog_product",
"condition_type": "eq"
}

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 26, 2017
@magento-engcom-team
Copy link
Contributor

@manhao-chen, thank you for your report.
We've created internal ticket(s) MAGETWO-80065 to track progress on the issue.

This was referenced Oct 13, 2017
Closed
Merged
Merged
Merged
@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Oct 25, 2017 •
edited
Loading

These internal tickets MAGETWO-73867, MAGETWO-59723 exist for this issue.

magento-team pushed a commit that referenced this issue Oct 26, 2017
@ishakhsuvarov
MAGETWO-81904: FIX #11022 in 2.2-develop: Filter Groups of search cri…
f3f257a 
…teria parameter have not been included for further processing #11421
magento-team pushed a commit that referenced this issue Oct 26, 2017
@ishakhsuvarov
Merge pull request #1625 from magento-engcom/2.2-develop-prs
04140ba 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82724 Allow coupon code with special charater to be applied to order in checkout #11710
 - MAGETWO-82675 Add a health check to the NGINX configuration sample #11690
 - MAGETWO-82562 Coupon codes not showing in invoice #11635
 - MAGETWO-82535 Fixed ability to set field config from layout xml #11302 [backport 2.2] #11643
 - MAGETWO-81146 Fixing #10275 keyboard submit of adminhtml suggest form. #11250
 - MAGETWO-82761 [Backport 2.2-develop] Dashboard Fix Y Axis for range #11751
 - MAGETWO-82748 Fix Notice: freePackageValue is undefined #11720
 - MAGETWO-82747 [TASK] Updated user.ini according to Magento DevDocs #11734
 - MAGETWO-82537 MAGETWO-81311: Check the length of the array before attempting to sli… #11637
 - MAGETWO-81970 Add missing translations in Magento_UI #11440
 - MAGETWO-81904 FIX #11022 in 2.2-develop: Filter Groups of search criteria parameter have not been included for further processing #11421
 - MAGETWO-82179 Fix Filter Customer Report Review 2.2-develop [Backport] #11522
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81904

@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release soon

@okorshenko okorshenko reopened this Oct 26, 2017
okorshenko pushed a commit that referenced this issue Oct 27, 2017
@dmanners
MAGETWO-81910: FIX #11022: Filter Groups of search criteria parameter…
ff5aaf6 
… have not been included for further processing #11418

 - Merge Pull Request #11418 from davidverholen/magento2:squashtoberfest-11022
 - Merged commits:
   1. 583d6dc
   2. 2220ab4
   3. 81e8313
okorshenko pushed a commit that referenced this issue Oct 27, 2017
@ishakhsuvarov
MAGETWO-81910: FIX #11022: Filter Groups of search criteria parameter…
de02e87 
… have not been included for further processing #11418
okorshenko pushed a commit that referenced this issue Oct 27, 2017
@ishakhsuvarov
Merge pull request #1634 from magento-engcom/develop-prs
07ed4b2 
[EngCom] Public Pull Requests - develop
- MAGETWO-82760: Dashboard Fix Y Axis for range #11752
- MAGETWO-81910: FIX #11022: Filter Groups of search criteria parameter have not been included for further processing #11418
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81910

okorshenko pushed a commit that referenced this issue Nov 9, 2017
@dmanners
MAGETWO-82487: FIX #11022 in 2.1-develop: Filter Groups of search cri…
55d0bba 
…teria parameter have not been included for further processing #11432

 - Merge Pull Request #11432 from davidverholen/magento2:squashtoberfest-11022-2.1
 - Merged commits:
   1. 93a0e57
   2. 051f95d
   3. 525f90a
   4. 6862394
   5. a3f3090
   6. 2a3ac2d
   7. e9339ca
okorshenko pushed a commit that referenced this issue Nov 9, 2017
@ishakhsuvarov
MAGETWO-82487: FIX #11022 in 2.1-develop: Filter Groups of search cri…
49f1c8f 
…teria parameter have not been included for further processing #11432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidverholen davidverholen

Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@manhao-chen @magento-team @davidverholen @okorshenko @TomashKhamlai @RomanKrut @magento-engcom-team