Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No button-primary__font-weight #15832

Closed
DanielRuf opened this issue Jun 5, 2018 · 4 comments
Closed

No button-primary__font-weight #15832

DanielRuf opened this issue Jun 5, 2018 · 4 comments
Assignees
@Karlasa
Labels
Area: Lib/Frontend Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 5, 2018 •
edited by Karlasa
Loading

Preconditions

Magento 2.2.4

Steps to reproduce

There is no @button-primary__font-weight for setting the font weight of the primary buttons.
(under lib/web/css/source/lib/variables/_buttons.less)

Expected result

Possibility to change only primary button font-weight without changing regular button font-weight with less variables

Actual result

Primary button don't have specific variable and falling back to variable @button__font-weight
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2018
@DanielRuf DanielRuf added Area: Lib/Frontend and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 5, 2018
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2018
@Karlasa
Copy link
Contributor

Karlasa commented Jun 11, 2018

@DanielRuf Primary button also don't have font-size and font-family variable and falling back to regular button settings. Not sure if it should be added? If yes, It's "good first issue" :)

@Karlasa Karlasa removed the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 11, 2018
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 11, 2018
@Karlasa Karlasa self-assigned this Jun 11, 2018
@Karlasa Karlasa mentioned this issue Jun 11, 2018
Merged
4 tasks
This was referenced Jun 12, 2018
Merged
Merged
@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 14, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 14, 2018

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16012 by @Karlasa in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@sidolov sidolov closed this as completed Jun 14, 2018
magento-engcom-team added a commit that referenced this issue Jun 14, 2018
@magento-engcom-team
ENGCOM-1952: Fix issue #15832 #16012
f3452c3 
 - Merge Pull Request #16012 from Karlasa/magento2:fix-15832
 - Merged commits:
   1. ab643ce
   2. dd007e3
magento-engcom-team pushed a commit that referenced this issue Jun 14, 2018
ENGCOM-1952: Fix issue #15832 #16012
a43bcf7
@sidolov
Copy link
Contributor

sidolov commented Jun 15, 2018

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16037 by @chirag-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 15, 2018
magento-engcom-team added a commit that referenced this issue Jun 15, 2018
@magento-engcom-team
ENGCOM-1989: [Backport] Fix issue #15832 #16037
eac6088 
 - Merge Pull Request #16037 from chirag-wagento/magento2:2.1-develop-PR-port-16012
 - Merged commits:
   1. 324ee50
   2. 41b4775
magento-engcom-team pushed a commit that referenced this issue Jun 15, 2018
ENGCOM-1989: [Backport] Fix issue #15832 #16037
e6269c5
@VladimirZaets
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16036 by @chirag-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 18, 2018
magento-engcom-team added a commit that referenced this issue Jun 18, 2018
@magento-engcom-team
ENGCOM-1990: [Forwardport] Fix issue #15832 #16036
fb07fdd 
 - Merge Pull Request #16036 from chirag-wagento/magento2:2.3-develop-PR-port-16012
 - Merged commits:
   1. d7e77e6
   2. c4de267
magento-engcom-team pushed a commit that referenced this issue Jun 18, 2018
ENGCOM-1990: [Forwardport] Fix issue #15832 #16036
c4f221e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karlasa Karlasa

Labels
Area: Lib/Frontend Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanielRuf @Karlasa @VladimirZaets @sidolov @magento-engcom-team