Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Name Prefix shows white space when extra separator is addes. #17861

Closed
sskulkarni opened this issue Aug 30, 2018 · 18 comments · Fixed by #20896
Closed

Customer Name Prefix shows white space when extra separator is addes. #17861

sskulkarni opened this issue Aug 30, 2018 · 18 comments · Fixed by #20896
Assignees
Labels
Component: Customer Event: mm19in Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@sskulkarni
Copy link

White space option is added when extra separator is added.

Preconditions

  1. php7.1
  2. Magento 2.2.5

Steps to reproduce

1.In admin menu Store->Configuration
Select "Customer Configuration" under confifuration.
Add "Mr;Ms;Mrs;" in "Prefix Dropdown Options"
prefix1

Expected result

  1. It should avoid the white space option, if extra separator is added.

Actual result

1.It is displaying extra white space option, and In case of it is required, It throws validation.
prefix2

@magento-engcom-team
Copy link
Contributor

Hi @sskulkarni. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@sskulkarni do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 30, 2018
@sskulkarni
Copy link
Author

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @sskulkarni. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sskulkarni, here is your Magento instance.
Admin access: https://i-17861-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sskulkarni
Copy link
Author

@magento-engcom-team
Reproduced in above instance.

@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Customer Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release help wanted labels Aug 30, 2018
@engcom-backlog-nickolas

Hello @sskulkarni, thank you for your report.
We've acknowledged the issue and added to our backlog.

@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Aug 30, 2018
@osrecio
Copy link
Member

osrecio commented Aug 30, 2018

What is exactly the problem? If you decide select the empty dropdown the validation shout out : "This is a required field." I think is a expected result

Thanks!

@sskulkarni
Copy link
Author

sskulkarni commented Aug 30, 2018

No, Actually Required field is not a problem.
Problem is that is we add "Mr;Ms;Mrs;" in admin.
The front end should reflect 3 dropdowns

  1. Mr
  2. Ms
  3. Mrs
    But now It shows

1: Mr
2: Ms
3: Mrs
4:

It should not consider the empty field and should be avoided by code.
Thanks.

@osrecio
Copy link
Member

osrecio commented Aug 30, 2018

but if you select the 4th option you get an error validation
screen shot 2018-08-30 at 10 47 17

@sskulkarni
Copy link
Author

Yes, that's fine, But my concern is 4th position should not display.
Only 3 dropdowns should.
Because It leads to confusion.
Thanks

@osrecio
Copy link
Member

osrecio commented Aug 30, 2018

Ok that's ok.
Maybe someone from Magento will can help us to determine if is an issue.

@osrecio
Copy link
Member

osrecio commented Aug 30, 2018

@engcom-backlog-nickolas Can you help to decide if is issue or not?

@ronak2ram
Copy link
Member

ronak2ram commented Aug 30, 2018

Hello @sskulkarni
Semicolon (;) separated values means put Semicolon (;) for separate two value.
You have to put like Mr;Ms;Mrs
Not need last Semicolon (;)

I think this not an issue.

@nainesh2jcommerce
Copy link
Contributor

I am currently working with Magento version 2.1.9 and facing same issue.

@shikhamis11 shikhamis11 self-assigned this Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@shikhamis11
Copy link
Member

#MM19IN

@magento-engcom-team
Copy link
Contributor

Hi @sskulkarni. Thank you for your report.
The issue has been fixed in #20896 by @shikhamis11 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

magento-engcom-team added a commit that referenced this issue Feb 14, 2019
… extra separator is addes #20896

 - Merge Pull Request #20896 from opencommerce/magento2:2.3-developPR17861
 - Merged commits:
   1. 8ff4aa5
magento-engcom-team added a commit that referenced this issue Feb 14, 2019
… extra separator is addes #20896

 - Merge Pull Request #20896 from opencommerce/magento2:2.3-developPR17861
 - Merged commits:
   1. 8ff4aa5
   2. fa72ee7
magento-engcom-team pushed a commit that referenced this issue Feb 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sskulkarni. Thank you for your report.
The issue has been fixed in #21245 by @mage2pratik in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 16, 2019
magento-engcom-team added a commit that referenced this issue Feb 16, 2019
… space when extra separator is addes #21245

 - Merge Pull Request #21245 from mage2pratik/magento2:2.2-develop-PR-port-20896
 - Merged commits:
   1. 77c780d
   2. 5eeecac
   3. 69cf6ce
magento-engcom-team pushed a commit that referenced this issue Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Event: mm19in Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
8 participants