Fixed #18823: Prefix dropdown in checkout doesn't select empty value by defau…

[mikebox]

Fixed #18823: Prefix dropdown in checkout doesn't select empty value by default if required

Description (*)

Added a condition to ensure the options provided by the customers start with the separator(;). If the separator exists at the start of the options, adding an empty option in the select.

Additional Notes:
array_filter() removes the empty characters. Removing that might create additional problems of having empty options in the middle. So added a condition to ensure the starting character and act based on that.

Fixed Issues (if relevant)

1. Prefix dropdown in checkout doesn't select empty value by default if required #18823: Prefix dropdown in checkout doesn't select empty value by default if required

Manual testing scenarios (*)

1. In Admin Backend go to Stores > Configuration > Customers > Name and Address Options
2. Set "Show Prefix" to "Required"
3. Set "Prefix Dropdown Options" to ";Mr.;Mrs."
4. Save Config
5. Go to your store
6. Add a item to your cart
7. Go to checkout

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mikebox. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lenaorobei]

Related to #20896

[lenaorobei]

As per discussion with PO @mbrinton01, the expected behavior is:
Mr;Ms; - select with Mr , Ms and ""
;Mr;Ms - select with "", Mr and Ms
;Mr;Ms;- select with "", Mr, Ms and ""

#17861 was configuration issue but not the functional.

[lenaorobei]

Please remove this check.

[lenaorobei]

Suggested change

	$options = array_filter(explode(';', $options));
	$options = explode(';', $options);

[lenaorobei]

@mikebox please see my comments and consider covering these cases with MFTF tests. Thank you.

[swnsma]

Hi @mikebox @lenaorobei
Could we use a little bit complex but more obvious approach called 'Dynamic Rows'?
https://devdocs.magento.com/guides/v2.3/ext-best-practices/tutorials/dynamic-row-system-config.html

[lenaorobei]

I like this idea! Let me confirm with @mbrinton01 since it will be a pretty big UI change and I believe we should take care of suffix as well.

[mbrinton01]

I'm fine with this approach as it should return the same experience for the user.

[engcom-Echo]

I will take care of test coverage.

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-6991 has been created to process this Pull Request

[engcom-Alfa]

.

[engcom-Alfa]

Hi @mikebox.

During testing, we faced the issue.

Problem: Prefix dropdown in checkout doesn't select an empty value by default

Manual testing scenario:

1. In Admin Backend go to Stores > Configuration > Customers > Name and Address Options;
2. Set "Show Prefix" to "Required";
3. Set "Prefix Dropdown Options" to ";Mr.;Mrs.";
4. Save Config and go to your store;
5. Add an item to your cart and go to checkout;

Actual Result: The value "Mr." is selected by default

@mikebox Could you take a look?

Thanks!

Pull Request state was updated. Re-review required.

[lenaorobei]

Closing this PR due to inactivity. Please feel free to reopen if you are going to continue working on it.
Thank you.

[m2-assistant]

Hi @mikebox, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.