Prefix dropdown in checkout doesn't select empty value by default if required

[engcom-Charlie]

Description (*)

Related Pull Requests

Fixes #18823

Fixed Issues (if relevant)

1. Prefix dropdown in checkout doesn't select empty value by default if required #18823:Prefix dropdown in checkout doesn't select empty value by default if required

Manual testing scenarios (*)

Please see #18823

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[engcom-Charlie]

@magento run all tests

[orlangur]

Let's first try to understand whether logic change is valid and only then apply necessary changes.

[engcom-Charlie]

Hi @orlangur, thank you for review, in the required field we add empty value only for it will be shown by default but we can't place an order with this on checkout or create a customer with blank value.

[engcom-Charlie]

@magento run all tests

[orlangur]

@engcom-Charlie thanks, need to check this behavior in action.

[engcom-Charlie]

Hi @orlangur, do You've any updates?

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7825 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Charlie]

Hi @ihor-sviziev, can You please review this PR?

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7825 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. In Admin Backend go to Stores > Configuration > Customers > Name and Address Options;
2. Set "Show Prefix" to "Required";
3. Set "Prefix Dropdown Options" to ";Mr;Mrs"
4. Save Config;
5. Go to your store;
6. Add an item to your cart;
7. Go to checkout;

Before: ✖️ Instead of having the empty value selected by default it will be always the first value selected.

After: ✔️ The empty value in the drop-down prefix was selected by default.

Case 2. Set Prefix to "Mr;Mrs;"

After: ✔️ Empty value at the end of the list

Case 3. Set Prefix to ";Mr;Ms;"

After: ✔️ Empty value at the beginning and end of the list

Note: As per comment, the expected behavior is:

Mr;Ms; - select with Mr , Ms and ""
;Mr;Ms - select with "", Mr and Ms
;Mr;Ms;- select with "", Mr, Ms and ""

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.