-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2.4.2 Customer Name Prefixes Showing as numbers not Mr., Mrs., Ms. etc #32177
Comments
Hi @likearocket. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Delta. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Delta Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
@magento I am working on it |
Hi @ashtonsax! 👋 |
@magento add to contributors team |
Hi @ashtonsax! 👋 |
@magento I am working on it |
This issue is caused by some questionable logic in In the
Although this solution does not solve the issue in the administration console's edit address for an order that's been processed as it seems to follow the same logic as the layout processor did to generate it's display. |
Any news on this? This is a very annoying bug and there seems to be no working patch around |
This is the patch we've used for the issue on the frontend of our magento stores as a quick fix, until a full range solution can be written and incorporated into Magento itself. Edit (21/06/21): |
I recently stumbled on this issue. As @Sental mentioned the issue was introduced with #28238. The issue #32066 seems also to be related. After the change to nummeric array index in the prefix options, the current value is no longer found and get added. My current fix is a composer patch, reverting the change from #28238. Composer patch for "magento/module-customer": |
This issue is still reproducible on Magento 2.4.4. |
I made a fix which works with no problems for me. I created after plugin on \Magento\Customer\Model\Options::getNamePrefixOptions method. It looks like this:
|
@Beraa995 Pretty cool! Thanks for sharing. It looks like you implemented your own "array_unique". I think you could reduce some lines of code by using the native array_unique-function. |
#36003 could maybe also fix it? |
The pull request #35060 has also been raised to fix this issue. |
The issue is reproducing in M2.4.3. Any solution for this? |
PR with the fix: #36003 |
Quick solution : edit this file : /vendor/magento/module-customer/Model/Options.php |
Well this is back again, if you change an order adres via admin the value is 0,1,2. @vutrankien's fix still applies |
Which version is it back in @stefanfr ? I will do another PR to fix it. |
@Sental Just ran into this issue on M2.4.4 when a new address is created in the checkout |
@Sental Didn't see your message, as @oskars-elksnitis said it is back since 2.4.4 and onwards, latest 2.4.6-p1 still has this issue:
|
After upgrading Magento from 2.4.1 to 2.4.2, customer orders are coming through with numbers instead of Name Prefixes such as Mr., Mrs. etc. No settings have been changed since the upgrade.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: