Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error when save configurable product in Magento 2.2.5 #18082

Closed
vpatidar009 opened this issue Sep 16, 2018 · 13 comments
Closed

Fatal Error when save configurable product in Magento 2.2.5 #18082

vpatidar009 opened this issue Sep 16, 2018 · 13 comments
Assignees
Labels
Component: ConfigurableProduct Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@vpatidar009
Copy link

Preconditions

PHP 7.1
MYSQL 5.6
Magento 2.2.5

Steps to reproduce

  1. Add new configurable product with name and sku of 63 characters length For Example: "Amzer 203877 Kristal FULL HD Tempered Glass for OnePlus 6 Clear". Screenshot: https://drive.google.com/file/d/1YQGb1h2J3oAfy6ihkCeZ7-Elbk6EYMaP/view?usp=drivesdk
  2. Create configuration of the product. Screenshot: https://drive.google.com/file/d/1EPspkolJGVhmSavKphDlIjOLT3k-QijU/view?usp=drivesdk
  3. Now, When you try to save it's configuration, It shows client side validation error for child products SKUs. Decrease length of child product's SKUs and then save the product. It generates a error report as attached. Screenshot: https://drive.google.com/file/d/1VTuD3gE2NVa3H1ndfi8xus7fGx2xUpDJ/view?usp=drivesdk

Expected result

  1. Save products without any error with SKU length less then or equal to 64

Actual result

1.Getting major error when save such product. even after decrease lenght of SKU to valid client side validation.

report.zip

@magento-engcom-team
Copy link
Contributor

Hi @vpatidar009. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@vpatidar009 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 16, 2018
@ghost ghost self-assigned this Sep 17, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 17, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label G1 Passed will be added to the issue automatically. Please, edit issue description if needed, until label G1 Passed appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add G2 Passed label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label acknowledged once verification is complete.

  • 7. Make sure that automatic system confirms that report is acknowledged.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Progress: needs update labels Sep 17, 2018
@ghost
Copy link

ghost commented Sep 17, 2018

Hi @vpatidar009 I'm not able to reproduce following steps you described, I'm not have an error report generated.

@vpatidar009
Copy link
Author

Hi @engcom-backlog-nazar ,
It is not possible as I have tested 2-3 instances of magento 2.2.5 version and all versions are vanilla magento.

I am pretty sure about the error and I can reproduce the issue at your environment if you can give me access of the environment.

@ghost ghost added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: needs update labels Sep 17, 2018
@vpatidar009
Copy link
Author

vpatidar009 commented Sep 17, 2018

@engcom-backlog-nazar https://github.com/magento/magento2/files/2386900/report.zip

I have also added screenshots URL in my initial message. Hope those screenshots will help you.

@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 17, 2018
@magento-engcom-team magento-engcom-team removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 17, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 17, 2018

@engcom-backlog-nazar Thank you for verifying the issue.

Unfortunately, not enough information was provided to created internal ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please label this ticket with "acknowledged" again.
Thanks!

@ghost ghost added Component: ConfigurableProduct Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 17, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-95055 were created

@ghost
Copy link

ghost commented Sep 17, 2018

@vpatidar009 , thank you for your report.
We've acknowledge the issue and added to our backlog.

@ghost ghost removed their assignment Sep 17, 2018
@vpatidar009
Copy link
Author

@magento-engcom-team @engcom-backlog-nazar We can also force sku length in the file "vendor\magento\module-configurable-product\view\adminhtml\web\js\variations\steps\summary.js" by 64 or less characters

@thiagolima-bm thiagolima-bm self-assigned this Oct 8, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 8, 2018

Hi @thiagolima-bm. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@Shubham0492
Copy link

#SQUASHTOBERFEST

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 6, 2018
@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2018

Hi @vpatidar009. Thank you for your report.
The issue has been fixed in #18462 by @thiagolima-bm in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov closed this as completed Nov 6, 2018
magento-engcom-team added a commit that referenced this issue Nov 6, 2018
… product in Magento 2.2.5 #18082 #18461 #18462

 - Merge Pull Request #18462 from thiagolima-bm/magento2:ISSUE/18082
 - Merged commits:
   1. cc16df9
   2. 7711165
@magento-engcom-team
Copy link
Contributor

Hi @vpatidar009. Thank you for your report.
The issue has been fixed in #18461 by @thiagolima-bm in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

magento-engcom-team added a commit that referenced this issue Nov 9, 2018
…o 2.2.5 #18082 #18461

 - Merge Pull Request #18461 from thiagolima-bm/magento2:issue/18082
 - Merged commits:
   1. 03698da
   2. 38854b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ConfigurableProduct Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants