fix Fatal Error when save configurable product in Magento 2.2.5 #18082 #18461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Interactiv4
|
|
sidolov
approved these changes
Oct 8, 2018
sidolov
approved these changes
Oct 8, 2018
|
Hi @sidolov, thank you for the review. |
magento-engcom-team
added a commit
that referenced
this pull request
Nov 6, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 6, 2018
Accepted Public Pull Requests: - #19066: Add additional check if password hash is empty in auth process (by @progreg) - #19026: #18256: Reset password throws error since 2.2.6. (by @p-bystritsky) - #19040: [Forwardport] save downloadable product links for order items (by @swnsma) - #19048: WYSIWYG unable to set default value in ui component (by @omiroshnichenko) - #19050: Add/update newsletter messages in translation file (by @arnoudhgz) - #19029: 18901-Forgot-password-form-should-not-available-while-customer-is-log� (by @agorbulin) - #19010: Fix for Internet Explorer 11: Edit customer in backend leads sometimes to a "loading circle" and error object does not support method "includes" (by @omiroshnichenko) - #18991: #10440: [Forwardport] Missing $debugHintsPath when sending email via command. (by @p-bystritsky) - #18988: [Forwardport] #17890: show correct text swatch values per store view (by @nmalevanec) - #18650: issue fixed -Wrong order total in customer information orders tab in admin panel (by @anujwebkul) - #18938: issue #18931 fixed. (by @ayazwebkul) - #18968: Fix numeric translation keys being dissolved by array_merge (by @tdgroot) - #18680: fix: cache count() results for loops (by @DanielRuf) - magento-engcom/import-export-improvements#142: Added $websiteString property to test class (by @maxalmonte14) - #18810: magento-engcom/import-export-improvements#51: fix for uploader filepath (by @sawebvisum) - #18083: Convert string to DateTime object for languages other than English (by @bnymn) - #18462: [forwardport 2.3] fix Fatal Error when save configurable product in Magento 2.2.5 #18082 #18461 (by @thiagolima-bm) Fixed GitHub Issues: - #19060: User created by admin cannot login (reported by @tomekjordan) has been fixed in #19066 by @progreg in 2.3-develop branch Related commits: 1. ed66491 - #18256: Reset password throws error since 2.2.6 (reported by @edwinbos) has been fixed in #19026 by @p-bystritsky in 2.3-develop branch Related commits: 1. bc8d3d5 - #18323: Order confirmation email for guest checkout does not include download links (reported by @hsray) has been fixed in #19040 by @swnsma in 2.3-develop branch Related commits: 1. 5dc7add 2. e19d70e - #19003: salesInvoiceOrder REST API does not make downloadable products available (reported by @nthurston) has been fixed in #19040 by @swnsma in 2.3-develop branch Related commits: 1. 5dc7add 2. e19d70e - #19034: sales_order_item_save_commit_after and sales_order_save_commit_after events will never fire for guest checkout (reported by @swnsma) has been fixed in #19040 by @swnsma in 2.3-develop branch Related commits: 1. 5dc7add 2. e19d70e - #10048: WYSIWYG unable to set default value in ui component (reported by @milansimek) has been fixed in #19048 by @omiroshnichenko in 2.3-develop branch Related commits: 1. 70743fa - #18901: Forgot password form should not available while customer is logged in. (reported by @webkul-ratnesh) has been fixed in #19029 by @agorbulin in 2.3-develop branch Related commits: 1. 76d478f - #18562: Internet Explorer 11: Edit customer in backend leads sometimes to a "loading circle" and error object does not support method "includes" (reported by @amenk) has been fixed in #19010 by @omiroshnichenko in 2.3-develop branch Related commits: 1. ed26e55 - #10440: Missing $debugHintsPath when sending email via command (reported by @cykirsch) has been fixed in #18991 by @p-bystritsky in 2.3-develop branch Related commits: 1. 7c86822 - #17890: Magento 2.2.5 Product swatches does not shows correct value for related store view (reported by @magicaner) has been fixed in #18988 by @nmalevanec in 2.3-develop branch Related commits: 1. f359bbc - #18618: Wrong order total in customer information orders tab in admin panel (reported by @LordHansolo) has been fixed in #18650 by @anujwebkul in 2.3-develop branch Related commits: 1. 11290c5 - #18931: Product added to shopping cart / comparison list message not translated by default (reported by @arnoudhgz) has been fixed in #18938 by @ayazwebkul in 2.3-develop branch Related commits: 1. 4c25f0e 2. d64351b - #5037: Datetime Error on Newsletter Template (reported by @davideperrotta) has been fixed in #18083 by @bnymn in 2.3-develop branch Related commits: 1. ae42612 2. c4fa85b 3. 6bda779 4. a4f80a9 5. 14d9528 6. da580fc 7. 16a7f0b 8. 9315dd6 9. 42cd228 10. ddeaf36 11. 6cc9034 12. 28617c0 13. fd0ab03 14. 1b03c19 15. c6c2ffe 16. 502e5ac 17. 51e8fe7 18. a8c7768 19. 127b1b8 20. 526bfc9 21. edc962d 22. 4fe8c7a 23. e27de55 24. 0d0c210 - #18082: Fatal Error when save configurable product in Magento 2.2.5 (reported by @vpatidar009) has been fixed in #18462 by @thiagolima-bm in 2.3-develop branch Related commits: 1. cc16df9 2. 7711165
orlangur
approved these changes
Nov 7, 2018
|
Hi @orlangur, thank you for the review. |
|
Hi @thiagolima-bm. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Fatal Error when save configurable product in Magento 2.2.5 #18082