Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Rewrites are overwritten #21329

Closed
AnshuMishra17 opened this issue Feb 19, 2019 · 7 comments
Closed

URL Rewrites are overwritten #21329

AnshuMishra17 opened this issue Feb 19, 2019 · 7 comments
Labels
Component: UrlRewrite Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@AnshuMishra17
Copy link
Contributor

Preconditions (*)

I am able to reproduce the issue of the following Magento Open Source version

  1. 2.2.6
  2. 2.2.7

Steps to reproduce (*)

  1. Add multiple websites, for example I have three websites, each website has its own store and corresponding store view.
    step1
  2. Go to Catalog -> Product -> select any product and edit it.
    For example, I have selected product with id 1 (Joust Duffle Bag)
  3. From Store view dropdown, select Default Store View.
  4. Under the Search Engine Optimization, uncheck the Use Default Value checkbox for URL Key and modifiy the URL key and save the product.
    step4
  5. Now, in Marketing -> URL rewrites, try to find the url rewrite for your selected product and you will able to see your new rewrites.
  6. Now, from the product listing page, select the same product as in step 2 and select update attributes from the Actions dropdown.
    step5
  7. Select the website tab and in Add product to websites select any new website and save.
    For example, my product was already in main website, so I have selected website 2.
  8. Now again go in Marketing -> URL rewrites and try to find all the url rewrites for your product.
    You will see the URL rewrites that has been generated in step 4 and step 5 no longer exist and you will only see the latest rewrite that has been generated in step 7.
    step8

Expected result (*)

URL rewrites for all the websites should exist.

Actual result (*)

URL rewrites are overwritten.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019

Hi @AnshuMishra17. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@AnshuMishra17 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 19, 2019
@ghost ghost self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Cleanup Component: UrlRewrite Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release and removed Cleanup labels Feb 19, 2019
@mahesh-rajawat mahesh-rajawat self-assigned this Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 20, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98330, MAGETWO-98331 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 20, 2019
AnshuMishra17 added a commit to AnshuMishra17/magento2 that referenced this issue Feb 20, 2019
AnshuMishra17 added a commit to AnshuMishra17/magento2 that referenced this issue Feb 21, 2019
@mahesh-rajawat mahesh-rajawat removed their assignment Feb 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your report.
The issue has been fixed in #21462 by @AnshuMishra17 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 8, 2019
@Ctucker9233
Copy link

@magento-engcom-team Shouldn't this stay open until the the 2.2 backport is merged? This is how a lot of bug fixes get lost.

@Ctucker9233 Ctucker9233 reopened this Mar 30, 2019
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 30, 2019
@ghost
Copy link

ghost commented Apr 1, 2019

Hi @Ctucker9233 there is a backport PR, -> #21358

If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.

  • If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost closed this as completed Apr 1, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UrlRewrite Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants