Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite fix while product website update using mass action #21358

Closed
wants to merge 3 commits into from

Conversation

AnshuMishra17
Copy link
Contributor

Description (*)

URL rewrite fix while product website update using mass action

Fixed Issues (if relevant)

  1. URL Rewrites are overwritten  #21329: URL Rewrites are overwritten

Manual testing scenarios (*)

  1. Added multiple websites.
  2. Set URL key value at store level for any product.
  3. Added the product in a new website using website update via mass action.
  4. Removed product from a website using website update via mass action.

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

Hi @AnshuMishra17, any chance you can port this to 2.3 before we merge this to 2.2? Thanks!

@AnshuMishra17
Copy link
Contributor Author

@miguelbalparda Magento Port Tool (https://porting.engcom.dev.magento.com) is saying that I can't port unmerged PR.
Do I need to create a separate PR, then?

@miguelbalparda
Copy link
Contributor

Yes, since the change is pretty small in LOC you should be able to create a new PR pointing to the correct branch without much hassle. No need to close this one. Thanks!

@AnshuMishra17
Copy link
Contributor Author

@miguelbalparda Can I edit the PR and change the base?

@AnshuMishra17
Copy link
Contributor Author

@miguelbalparda I have created a new PR #21462

@ghost ghost mentioned this pull request Apr 1, 2019
@ghost ghost assigned sidolov May 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5193 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

Hi @AnshuMishra17 I am not able to reproduce issue #21329 on 2.2-develop.
#21358CantReproduce
Could you take a look?

@sidolov
Copy link
Contributor

sidolov commented Jun 18, 2019

@AnshuMishra17 , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jun 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2019

Hi @AnshuMishra17, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants