Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite fix while product website update using mass action #21358

Closed
wants to merge 3 commits into from
Closed

rewrite fix while product website update using mass action #21358

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a2290
issue #21329 rewrite fix while product website update using mass action
AnshuMishra17 Feb 20, 2019
fbda060
issue #21329 rewrite fix while product website update using mass action
AnshuMishra17 Feb 21, 2019
323dfa6
Merge branch '2.2-develop' into issue-21329
AnshuMishra17 Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions app/code/Magento/CatalogUrlRewrite/Observer/ProductToWebsiteChangeObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
use Magento\Store\Model\Store;
use Magento\UrlRewrite\Model\UrlPersistInterface;
use Magento\UrlRewrite\Service\V1\Data\UrlRewrite;
use Magento\Store\Api\StoreWebsiteRelationInterface;
use Magento\Framework\App\ObjectManager;
use Magento\Framework\Exception\NoSuchEntityException;
use Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException;

Expand Down Expand Up @@ -41,22 +43,31 @@ class ProductToWebsiteChangeObserver implements ObserverInterface
*/
protected $request;

/**
* @var StoreWebsiteRelationInterface
*/
private $storeWebsiteRelation;

/**
* @param ProductUrlRewriteGenerator $productUrlRewriteGenerator
* @param UrlPersistInterface $urlPersist
* @param ProductRepositoryInterface $productRepository
* @param RequestInterface $request
* @param StoreWebsiteRelationInterface $storeWebsiteRelation
*/
public function __construct(
ProductUrlRewriteGenerator $productUrlRewriteGenerator,
UrlPersistInterface $urlPersist,
ProductRepositoryInterface $productRepository,
RequestInterface $request
RequestInterface $request,
StoreWebsiteRelationInterface $storeWebsiteRelation = null
) {
$this->productUrlRewriteGenerator = $productUrlRewriteGenerator;
$this->urlPersist = $urlPersist;
$this->productRepository = $productRepository;
$this->request = $request;
$this->storeWebsiteRelation = $storeWebsiteRelation ?:
ObjectManager::getInstance()->get(StoreWebsiteRelationInterface::class);
}

/**
Expand All @@ -79,11 +90,18 @@ public function execute(\Magento\Framework\Event\Observer $observer)
);

if (!empty($this->productUrlRewriteGenerator->generate($product))) {
$this->urlPersist->deleteByData([
UrlRewrite::ENTITY_ID => $product->getId(),
UrlRewrite::ENTITY_TYPE => ProductUrlRewriteGenerator::ENTITY_TYPE,
UrlRewrite::STORE_ID => $storeId,
]);
if ($this->request->getParam('remove_website_ids')) {
foreach ($this->request->getParam('remove_website_ids') as $webId) {
foreach ($this->storeWebsiteRelation->getStoreByWebsiteId($webId) as $storeId) {
$this->urlPersist->deleteByData([
UrlRewrite::ENTITY_ID => $product->getId(),
UrlRewrite::ENTITY_TYPE => ProductUrlRewriteGenerator::ENTITY_TYPE,
UrlRewrite::STORE_ID => $storeId
]);
}
}
}

if ($product->getVisibility() != Visibility::VISIBILITY_NOT_VISIBLE) {
$this->urlPersist->replace($this->productUrlRewriteGenerator->generate($product));
}
Expand Down