Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config:set -le and -lc short form options don't work #22395

Closed
MichaelThessel opened this issue Apr 17, 2019 · 9 comments · Fixed by #22720
Closed

config:set -le and -lc short form options don't work #22395

MichaelThessel opened this issue Apr 17, 2019 · 9 comments · Fixed by #22720
Assignees
@satyaprakashpatel
Labels
Component: Config Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@MichaelThessel
Copy link

Preconditions (*)

  1. 2.3.1

Steps to reproduce (*)

  1. bin/magento config:set --scope default -lc

Expected result (*)

  1. -lc option is applied

Actual result (*)

  1. Error message appears:

The "-c" option does not exist.

The long form versions (--lock-env, --lock-config) of those options work fine
@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2019 •
edited by kalpmehta
Loading

Hi @MichaelThessel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@MichaelThessel do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 17, 2019
@kalpmehta kalpmehta self-assigned this Apr 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2019 •
edited by kalpmehta
Loading

Hi @kalpmehta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@kalpmehta kalpmehta added Component: Config Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 17, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Apr 17, 2019 •
edited by kalpmehta
Loading

@kalpmehta Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 17, 2019
@kalpmehta kalpmehta added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 18, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @kalpmehta
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99254 were created

Issue Available: @kalpmehta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 18, 2019
@shikhamis11 shikhamis11 self-assigned this Apr 30, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2019 •
edited by shikhamis11
Loading

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@shikhamis11
Copy link
Member

I am working on this at #dmcdindia1

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @satyaprakashpatel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

satyaprakashpatel added a commit to satyaprakashpatel/magento2 that referenced this issue May 4, 2019
@satyaprakashpatel
Fixed:magento#22395
fbcfd11 
Fixed  magento#22395: config:set -le and -lc short form options don't work
@satyaprakashpatel satyaprakashpatel mentioned this issue May 4, 2019
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @MichaelThessel. Thank you for your report.
The issue has been fixed in #22720 by @satyaprakashpatel in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label May 8, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this issue May 8, 2019
@magento-engcom-team
ENGCOM-5056: Fixed:magento#22395 magento#22720
ff4c8cc 
 - Merge Pull Request magento#22720 from satyaprakashpatel/magento2:2.3-develop-config-set-short
 - Merged commits:
   1. fbcfd11
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this issue May 8, 2019
@magento-engcom-team
ENGCOM-5056: Fixed:magento#22395 magento#22720
2042c30 
 - Merge Pull Request magento#22720 from satyaprakashpatel/magento2:2.3-develop-config-set-short
 - Merged commits:
   1. fbcfd11
   2. 62cbf5b
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this issue May 8, 2019
@sivaschenko
ENGCOM-5056: Fixed:magento#22395 magento#22720
a3bd403
@shikhamis11 shikhamis11 mentioned this issue May 11, 2019
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @MichaelThessel. Thank you for your report.
The issue has been fixed in #22836 by @shikhamis11 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team added a commit that referenced this issue May 17, 2019
@magento-engcom-team
ENGCOM-5102: [Backport] Fixed:#22395 #22836
35cabff 
 - Merge Pull Request #22836 from shikhamis11/magento2:2.2-develop-PR-port-22720
 - Merged commits:
   1. df7fad8
   2. 2e7c766
magento-engcom-team pushed a commit that referenced this issue May 17, 2019
@VladimirZaets
ENGCOM-5102: [Backport] Fixed:#22395 #22836
262bd66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satyaprakashpatel satyaprakashpatel

Labels
Component: Config Event: dmcdindia1 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed:#22395 satyaprakashpatel/magento2
5 participants
@MichaelThessel @kalpmehta @satyaprakashpatel @shikhamis11 @magento-engcom-team