Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed:#22395 #22836

Merged
merged 2 commits into from
May 17, 2019
Merged

[Backport] Fixed:#22395 #22836

merged 2 commits into from
May 17, 2019

Conversation

shikhamis11
Copy link
Member

Original Pull Request

#22720
Fixed #22395: config:set -le and -lc short form options don't work
Note : updated short command lc to c and le to e as symfony takes single character as a short option.

Preconditions (*)

  1. 2.3.1

Steps to reproduce (*)

  1. bin/magento config:set --scope default -lc

Expected result (*)

  1. -lc option is applied

Actual result (*)

  1. Error message appears:

The "-c" option does not exist.

The long form versions (--lock-env, --lock-config) of those options work fine

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

satyaprakashpatel and others added 2 commits May 11, 2019 20:29
Fixed  #22395: config:set -le and -lc short form options don't work
@m2-assistant
Copy link

m2-assistant bot commented May 11, 2019

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5102 has been created to process this Pull Request

@ghost ghost assigned kalpmehta May 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5102 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants