About ByPercent.php under different currencies #581
Assignees
Labels
bug report
Issue: Ready for Work
Gate 4. Acknowledged. Issue is added to backlog and ready for development
Comments
|
@tmp2000, thank you for reporting this issue to us! We created the ticket in the backlog and will have the person responsible for the area take a look at it. We will get back to you once we complete the analysis. |
|
Ticket: MAGETWO-25084 |
vpelipenko
added
the
Issue: Ready for Work
|
@tmp2000, fix will be delivered with next publication. |
magento-team
pushed a commit
that referenced
this issue
Jan 23, 2015
magento-team
pushed a commit
that referenced
this issue
Jan 23, 2015
|
This issue is fixed and available in 0.42.0-beta5. |
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this issue
Feb 9, 2015
* UI improvements:
* Updated the design of Enable Cookies CMS page
* Implemented UI improvements for Widgets
* Fixed the "Help Us to Keep Magento Healthy Report All Bugs (ver. #)" link Magento Admin
* Various UI improvements
* Various improvements:
* Implemented Sales Quote as a standalone Magento module
* Performed custom EAV entities code and DB tables cleanup
* Eliminating remnants of the Core module:
* Moved Application Emulation from the Magento_Core module to the Magento_Store module
* Moved Validator Factory from the Magento_Core module to the Magento Framework
* Added static integrity test for composer.json files
* Added PHPMD and PHPCS annotations to the codebase
* Tests improvements:
* Added MVP tag to the functional tests
* Created acceptance functional test suite
* Replaced end-to-end tests for url rewrite creation, CMS page creation, category creation, review creation, customer frontend creation, and tax rule creation with injectable tests
* Automated test cases for downloadable products with taxes
* Fixed bugs:
* Fixed an issue where the Discounts and Coupons RSS Feed had incorrect title
* Fixed an issue where a wrong special price expiration date was displayed in RSS
* Fixed an issue in the Import functionality where imported files disappeared after the Check Data operation
* Fixed an issue where the Unsubscribe link in the Newsletter was broken
* Fixed an issue where stock status changed incorrectly after import
* Fixed an issue where selected filters and exclude did not work during Export
* Fixed an issue where tax details order was different on order/invoice/refund create and view pages (
* Fixed a typo in the getCalculationAlgorithm public function
* Fixed an issue where the incorrect value of Subtotal Including Tax was displayed in invoices
* Fixed an issue where tax details were not displayed on a new order
* Improved pricing performance using caching
* Fixed an issue where CsvImportHandler tests still referring to links from Tax module instead of TaxImportExport module
* Fixed an issue where an exception was thrown instead of 404 if altering the url for a product with required configuration on the storefront
* Fixed an issue where the title of successfully placed order page (was empty
* Fixed an issue where certain fields were not disabled by default on the website scope in System configuration as expected
* Fixed an issue where third party interfaces were not supported by single-tenant compiler
* Eliminated the 'protocol' parameter from the ReadInterface and WriteInterface
* GitHub requests:
* [#979](magento/magento2#979) -- Adding OSL license file name
* [#978](magento/magento2#978) -- Added ignore rule for media assets in wysiwyg directory
* [#877](magento/magento2#877) -- Made Topmenu HTML Editable
* [#906](magento/magento2#906) -- Add tests for View\Layout\Reader\Block and slight refactoring
* [#682](magento/magento2#682) -- \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code
* [#581](magento/magento2#581) -- About ByPercent.php under different currencies
* [#964](magento/magento2#964) -- Improving documentation for jMeter performance tests
* [#871](magento/magento2#871) -- Replace Symfony2/Yaml in composer
* [#990](magento/magento2#990) -- add @see annotation before class to make it recognizable by IDE
* [#988](magento/magento2#988) -- Prevent Varnish from creating cache variations of static files
* Framework improvements:
* Improved unit and integration tests coverage
taskula
pushed a commit
to Hypernova-Oy/magento2
that referenced
this issue
Apr 25, 2019
taskula
pushed a commit
to Hypernova-Oy/magento2
that referenced
this issue
Apr 25, 2019
taskula
pushed a commit
to Hypernova-Oy/magento2
that referenced
this issue
Apr 25, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this issue
Dec 4, 2023
ACPT-1688: Fix Static Tests failures on Application-Server branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found since magento 1.7 to 2.0 ,the logic is the same for ByPercent shopping cart rule for
$discountData->setBaseOriginalAmount(($qty * $baseItemOriginalPrice - $item->getDiscountAmount()) * $_rulePct);
The problem exists for mutli currencies:
If quote currency is different with web currency,and there is already one shopping cart price rule applied before for the item in the shopping cart,then the $item->getDiscountAmount() would be the discount value under the quote currency,while $baseItemOriginalPrice is web currency ,so it would be wrong for this substract logic.
The text was updated successfully, but these errors were encountered: