Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Symfony2/Yaml in composer #871

Closed
jamescowie opened this issue Dec 24, 2014 · 9 comments
Closed

Replace Symfony2/Yaml in composer #871

jamescowie opened this issue Dec 24, 2014 · 9 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@jamescowie
Copy link

Is there any specific reason why we need to do:

"symfony/yaml": "2.3.x-dev", in composer.json file ?
@buskamuza
Copy link
Contributor

No reason. It had to be removed together with the library.
Thanks for reporting this issue, we'll work on cleanup of composer.json file.

@orlangur
Copy link
Contributor

The reason was

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for phpunit/phpunit 4.1.0 -> satisfiable by phpunit/phpunit[4.1.0].
    - phpunit/phpunit 4.1.0 requires symfony/yaml ~2.0 -> no matching package found.

It can be avoided by composer.lock added to repository.

@jamescowie
Copy link
Author

Is adding the composer.lock file part of the roadmap for a future release ? Im working on MageSpec and this relies on having symfony/yaml available to read the configuration file.

@maksek maksek added the PS label Dec 26, 2014
@orlangur
Copy link
Contributor

composer.lock will appear in regular weekly update. It will fully correspond to root composer.json. With some of next updates to fix issue you mentioned symfony/yaml will be removed from both files as this component is not used in M2 currently.

To have symfony/yaml available for your project, just specify it as a requirement instead of relying on M2 dependency.

@buskamuza
Copy link
Contributor

symfony/yaml is specified in replace section, so Composer will assume that it's already included in Magento project and "specifying it as a requirement" will not help.
The task of fixing composer.json is currently in progress, so it should be in the public GitHub with one of the next updates.

composer.lock is already present in the repository.

@jamescowie
Copy link
Author

Thanks for the replies all. MageSpec / PHPSpec has symfony/yaml set as a dependency but because of the Magento2 composer replace flag this is removed resulting in the class not found error.

It looks like you have it in hand with adding the composer.lock file. For the time being I have removed the replace in my branch so I can continue working on PHPSpec for Magento 2. When the next push is made I will revert this change and re test.

@verklov
Copy link
Contributor

verklov commented Jan 5, 2015

Internal ticket: MAGETWO-32346

magento-team pushed a commit that referenced this issue Jan 9, 2015
@orlangur
MAGETWO-32346: [GITHUB] Replace Symfony2/Yaml in composer #871
0479686 
- update composer.lock with "composer update symfony/yaml"
@muasir muasir added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 23, 2015
@vpelipenko
Copy link
Contributor

@jamescowie, changes in the source code according issue you placed are already published and available from 0.42.0-beta5. Are you OK with that? Can we close this issue?

@jamescowie
Copy link
Author

Hello. Thanks for the reply. After testing I am happy for this to be closed now..

magento-team added a commit to abeeskau/magento2-community-edition that referenced this issue Feb 9, 2015
@magento-team
0.42.0-beta5
868391e 
* UI improvements:
    * Updated the design of Enable Cookies CMS page
    * Implemented UI improvements for Widgets
    * Fixed the "Help Us to Keep Magento Healthy Report All Bugs (ver. #)" link Magento Admin
    * Various UI improvements
* Various improvements:
    * Implemented Sales Quote as a standalone Magento module
    * Performed custom EAV entities code and DB tables cleanup
    * Eliminating remnants of the Core module:
        * Moved Application Emulation from the Magento_Core module to the Magento_Store module
        * Moved Validator Factory from the Magento_Core module to the Magento Framework
    * Added static integrity test for composer.json files
    * Added PHPMD and PHPCS annotations to the codebase
* Tests improvements:
    * Added MVP tag to the functional tests
    * Created acceptance functional test suite
    * Replaced end-to-end tests for url rewrite creation, CMS page creation, category creation, review creation, customer frontend creation, and tax rule creation with injectable tests
    * Automated test cases for downloadable products with taxes
* Fixed bugs:
    * Fixed an issue where the Discounts and Coupons RSS Feed had incorrect title
    * Fixed an issue where a wrong special price expiration date was displayed in RSS
    * Fixed an issue in the Import functionality where imported files disappeared after the Check Data operation
    * Fixed an issue where the Unsubscribe link in the Newsletter was broken
    * Fixed an issue where stock status changed incorrectly after import
    * Fixed an issue where selected filters and exclude did not work during Export
    * Fixed an issue where tax details order was different on order/invoice/refund create and view pages (
    * Fixed a typo in the getCalculationAlgorithm public function
    * Fixed an issue where the incorrect value of Subtotal Including Tax was displayed in invoices
    * Fixed an issue where tax details were not displayed on a new order
    * Improved pricing performance using caching
    * Fixed an issue where CsvImportHandler tests still referring to links from Tax module instead of TaxImportExport module
    * Fixed an issue where an exception was thrown instead of 404 if altering the url for a product with required configuration on the storefront
    * Fixed an issue where the title of successfully placed order page (was empty
    * Fixed an issue where certain fields were not disabled by default on the website scope in System configuration as expected
    * Fixed an issue where third party interfaces were not supported by single-tenant compiler
    * Eliminated the 'protocol' parameter from the ReadInterface and WriteInterface
* GitHub requests:
    * [#979](magento/magento2#979) -- Adding OSL license file name
    * [#978](magento/magento2#978) -- Added ignore rule for media assets in wysiwyg directory
    * [#877](magento/magento2#877) -- Made Topmenu HTML Editable
    * [#906](magento/magento2#906) -- Add tests for View\Layout\Reader\Block and slight refactoring
    * [#682](magento/magento2#682) -- \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code
    * [#581](magento/magento2#581) -- About ByPercent.php under different currencies
    * [#964](magento/magento2#964) -- Improving documentation for jMeter performance tests
    * [#871](magento/magento2#871) -- Replace Symfony2/Yaml in composer
    * [#990](magento/magento2#990) -- add @see annotation before class to make it recognizable by IDE
    * [#988](magento/magento2#988) -- Prevent Varnish from creating cache variations of static files
* Framework improvements:
    * Improved unit and integration tests coverage
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this issue Apr 29, 2018
@maghamed
Merge pull request magento#871 from magento-engcom/get-source-action-…
cde574a 
…all-items-it-one-call

Refacoring: Source Selection Algoritm on Shipping page - call by all requestedItems
danslo added a commit that referenced this issue Oct 21, 2019
@danslo
also thrown an exception when provided store is not enabled
e159faf 
Closes #871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@muasir @orlangur @jamescowie @maksek @buskamuza @verklov @vpelipenko