Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.1.1 Problem with change currency #6746

Closed
Omar-Oleh opened this issue Sep 25, 2016 · 16 comments
Closed

Magento 2.1.1 Problem with change currency #6746

Omar-Oleh opened this issue Sep 25, 2016 · 16 comments
Labels
bug report Component: Framework/Cache Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Omar-Oleh
Copy link

Preconditions
Magento 2.1.1
Created two currencies (United Arab Emirates Dirham and Qatari Rial)
Cache is enabled

Steps to reproduce
Open category page on frontend
Change currency

Expected result
Currency is changed on product listing

Actual result
Currency do not changed. Problem with FPC(I have refreshed FPC, the currency is work fine. But if I changed currency one more, it is do not working)

@SerhiyShkolyarenko
Copy link
Contributor

@Omar-Oleh have you created currency rates?
What is base currency for your store?

@SerhiyShkolyarenko SerhiyShkolyarenko added Progress: needs update Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Sep 28, 2016
@SerhiyShkolyarenko
Copy link
Contributor

@Omar-Oleh reproduced. Answers to that questions are not necessary. Thank you for reporting issue!

@SerhiyShkolyarenko
Copy link
Contributor

Our internal issue is MAGETWO-59089.

mmansoor-magento pushed a commit that referenced this issue Oct 5, 2016
…ETWO-59089

Fixed issues:

- MAGETWO-59089 [Github]Magento 2.1.1 Problem with change currency #6746
@eldonbite
Copy link

We're experiencing the same when switching between GBP and JPY currencies:

image

image

Some workarounds that I know of to prevent this issue from occurring is to:

  1. Disable the block cache (BLOCK_HTML)
  2. Edit Magento\Framework\Pricing\Render\PriceBox and either:
    • set the DEFAULT_LIFETIME to 0, or
    • just force getCacheLifetime to return 0

I tried writing an extension to override this behaviour, to no avail (I might be doing something wrong LOL). But it still doesn't solve the root cause of the problem.

@SerhiyShkolyarenko
Copy link
Contributor

Fix is delivered to mainline. Closing the issue.

@Ctucker9233
Copy link

@SerhiyShkolyarenko is there a commit reference?

@SerhiyShkolyarenko
Copy link
Contributor

SerhiyShkolyarenko commented Nov 1, 2016

There we six commits for this issue: 8ec49df, 027491e, be4d557, 0d0e683, b1066bf, e908e6c

@eldonbite
Copy link

eldonbite commented Nov 4, 2016

Hi @SerhiyShkolyarenko,

Noticed another issue when selecting product variants using the swatches.

  1. GBP:
    image
  2. Select a product variant while in GBP:
    image
  3. Then, switch currency to JPY:
    image
  4. Upon selecting a product variant, the price reverts back to the GBP amount but with JPY currency symbol:
    image

@SerhiyShkolyarenko
Copy link
Contributor

@eldonbite thank you for the notice.
It looks like a different issue. Could you please create a separate issue for it?

@eldonbite
Copy link

eldonbite commented Nov 9, 2016

Hi @SerhiyShkolyarenko,

I created an issue for the problem described above:

#7371 Wrong price upon selecting product options after switching currency

Thanks and regards,
Eldon

@SerhiyShkolyarenko
Copy link
Contributor

thanks @eldonbite!

@duytrinhit
Copy link

duytrinhit commented Mar 30, 2017

Hi @eldonbite @Omar-Oleh @Ctucker9233
I have created a small cript to override FinalPriceBox Block
Now the problem is resolved. Please try my code in below link
https://github.com/duytrinhit/magento2/tree/master/app/code/Balance/Catalog

hostep pushed a commit to hostep/magento2 that referenced this issue Jun 3, 2017
… change currency

Fixed issues:

- MAGETWO-59089 [Github]Magento 2.1.1 Problem with change currency magento#6746
(cherry picked from commit a9510d3)
@korostii
Copy link
Contributor

korostii commented Jun 6, 2017

@SerhiyShkolyarenko, could you please reopen this until the fix is delivered into a release? Thanks in advance.

The issue is clearly reported for 2.1.x. It is only reasonable to expect this fix in a 2.1.x release before closing the issue.

@yosefkurniawan
Copy link

is this issue solved?

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69665

magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
Fixed issues:

  - MAGETWO-60246 [Backport] - [Github]Magento 2.1.1 Problem with change currency #6746 - for 2.1.x
  - MAGETWO-70329 [GITHUB] The rich snippets are giving a warning for the element price #7173
  - MAGETWO-85781 Configurable product Final Price ignores Catalog Rule
  - MAGETWO-83204 "Hide from Product Page" option does not work for child of configurable product
  - MAGETWO-83094 Products Ordered Report exported CSV is empty
  - MAGETWO-71701 [Backport] - Catalog top nav, CSS class not set to active when using Varnish - for 2.1
  - MAGETWO-71229 Warning message is cached and shown a few times on the shopping cart
@techspot
Copy link

THIS SOLUTION WORK FOR ME: First i need select the country of the currency that i need, in Store Configuration > General > Store Information > Country

After i can change the currency in Currency Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Framework/Cache Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

10 participants