Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich snippets magento 2 - bug - price notation not right #7173

Closed
JamboMedia opened this issue Oct 25, 2016 · 11 comments
Closed

Rich snippets magento 2 - bug - price notation not right #7173

JamboMedia opened this issue Oct 25, 2016 · 11 comments
Labels
bug report Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@JamboMedia
Copy link

JamboMedia commented Oct 25, 2016 •
edited
Loading

Preconditions

Magento 2.1.2

Steps to reproduce

  1. Test a productpage from the demo shop

The rich snippets for magento 2 are giving a warning for the element price

https://search.google.com/structured-data/testing-tool#url=http%3A%2F%2Fmagento2demo.firebearstudio.com%2Fargus-all-weather-tank.html

The notation is now:

$22.00

The notation should be: (whithout the Currency)

22.00
@veloraven
Copy link
Contributor

Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.
Please, also identify exact version of Magento you are running.

@JamboMedia
Copy link
Author

Better?

@caseyjonesaustralia
Copy link

Same issue here v2.1.2
Can anyone provide a quick fix for this prior to the next release?

@fxdegroot
Copy link

Same issue for me in 2.1.2. Can we get any news or diff in order to fix this issue ?

@Pakkapao
Copy link

This works for me. Try updating <magento root>/vendor/magento/module-catalog/view/base/templates/product/price/amount/default.phtml

From:
<?php echo $block->getSchema() ? ' itemprop="price"' : '' ?>>

To:
<?php echo $block->getSchema() ? ' itemprop="price" content="' . $block->getDisplayValue() . '"': '' ?>>

Before:
before

After:
after

Reference: http://schema.org/price

Note that both RDFa and Microdata syntax allow the use of a "content=" attribute for publishing simple machine-readable values alongside more human-friendly formatting.

@hostep
Copy link
Contributor

hostep commented Feb 28, 2017

It looks like this was recently fixed by an accepted PR: #8132, albeit in a slightly different way then what @Pakkapao was suggesting.

Can somebody confirm? @okorshenko @avoelkl?

@avoelkl
Copy link
Contributor

avoelkl commented Mar 1, 2017

Thanks for the heads up @hostep, this was indeed resolved with #8132.

@Sergeacc
Copy link

Internal ticket created MAGETWO-70329

@hostep
Copy link
Contributor

hostep commented Jun 29, 2017

@Sergeacc: this was already fixed in #8132, or is this new MAGETWO ticket for backporting the fix to 2.1? Or am I missing something here? :)

@Sergeacc
Copy link

@hostep yes, this is new MAGETWO ticket for backporting the fix to 2.1

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 29, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: Tax labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Sep 21, 2017
@magento-engcom-team
Copy link
Contributor

@JamboMedia, thank you for your report.
The fix for this issue is already available in the develop branch. See PR #8132.

magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@VladimirZaets
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
2cd57d1 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@VladimirZaets
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
5a06c3a 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@VladimirZaets
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
94a9734 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@VladimirZaets
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
bc1d4c7 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@VladimirZaets
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
d7f89ba 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@dhorytskyi
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
3dff31f 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2018
@igrybkov
Merge pull request #2109 from magento-tango/2.1.13-PR-0.5
ce3efb6 
Fixed issues:

  - MAGETWO-60246 [Backport] - [Github]Magento 2.1.1 Problem with change currency #6746 - for 2.1.x
  - MAGETWO-70329 [GITHUB] The rich snippets are giving a warning for the element price #7173
  - MAGETWO-85781 Configurable product Final Price ignores Catalog Rule
  - MAGETWO-83204 "Hide from Product Page" option does not work for child of configurable product
  - MAGETWO-83094 Products Ordered Report exported CSV is empty
  - MAGETWO-71701 [Backport] - Catalog top nav, CSS class not set to active when using Varnish - for 2.1
  - MAGETWO-71229 Warning message is cached and shown a few times on the shopping cart
magento-engcom-team pushed a commit that referenced this issue Apr 24, 2018
@OlgaVasyltsun @dhorytskyi
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
fc17da8 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Apr 24, 2018
@dhorytskyi
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
e9550f6 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Apr 24, 2018
@dhorytskyi
MAGETWO-70329: [GITHUB] The rich snippets are giving a warning for th…
21a72ca 
…e element price #7173
magento-engcom-team pushed a commit that referenced this issue Apr 24, 2018
@dhorytskyi
Merge pull request #2437 from magento-tango/MAGETWO-70329-2
c462a13 
MAGETWO-70329 [GITHUB] The rich snippets are giving a warning for the element price #7173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@hostep @avoelkl @veloraven @caseyjonesaustralia @fxdegroot @Pakkapao @JamboMedia @Sergeacc @magento-engcom-team