Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "flying" submenu in MassAction dropdown with large number of elements #10651

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Fix for "flying" submenu in MassAction dropdown with large number of elements #10651

merged 1 commit into from
Aug 28, 2017

Conversation

xmav
Copy link
Contributor

@xmav xmav commented Aug 24, 2017

Fix for "flying" submenu in MassAction dropdown with large number of elements

Description

Submenu in grid MassAction dropdown displayed under list of elements in case of large number of elements.

Manual testing scenarios

  1. Update app/code/Magento/Catalog/view/adminhtml/ui_component/product_listing.xml and add dummy MassAction dropdown items before "Change Status"
 <action name="testMenu1">
                <settings>
                    <type>testMenu1</type>
                    <label translate="true">testMenu1</label>
                </settings>
            </action>
            <action name="testMenu2">
                <settings>
                    <type>testMenu2</type>
                    <label translate="true">testMenu2</label>
                </settings>
            </action>
            <action name="testMenu3">
                <settings>
                    <type>testMenu3</type>
                    <label translate="true">testMenu3</label>
                </settings>
            </action>
            <action name="testMenu4">
                <settings>
                    <type>testMenu4</type>
                    <label translate="true">testMenu4</label>
                </settings>
            </action>
            <action name="testMenu5">
                <settings>
                    <type>testMenu5</type>
                    <label translate="true">testMenu5</label>
                </settings>
            </action>
            <action name="testMenu6">
                <settings>
                    <type>testMenu6</type>
                    <label translate="true">testMenu6</label>
                </settings>
            </action>
            <action name="testMenu7">
                <settings>
                    <type>testMenu7</type>
                    <label translate="true">testMenu7</label>
                </settings>
            </action>
            <action name="testMenu8">
                <settings>
                    <type>testMenu8</type>
                    <label translate="true">testMenu8</label>
                </settings>
            </action>
            <action name="testMenu9">
                <settings>
                    <type>testMenu9</type>
                    <label translate="true">testMenu9</label>
                </settings>
            </action>
            <action name="testMenu10">
                <settings>
                    <type>testMenu10</type>
                    <label translate="true">testMenu10</label>
                </settings>
            </action>
            <action name="testMenu11">
                <settings>
                    <type>testMenu11</type>
                    <label translate="true">testMenu11</label>
                </settings>
            </action>
  1. Login to backed
  2. Go to Catalog -> Products
  3. Open MassAction drop down scroll to Change Status and click
    Actual result:
    Submenu appears under dropdown elements list.
    screenshot from 2017-08-24 21-05-26

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Aug 25, 2017
@okorshenko okorshenko added this to the August 2017 milestone Aug 25, 2017
@magento-team magento-team merged commit 81e729c into magento:develop Aug 28, 2017
magento-team pushed a commit that referenced this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants