Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Massaction design with submenu on grid pages #20938

Conversation

ananth-iyer
Copy link
Member

Description (*)

Fixed Issues (if relevant)

  1. Admin product grid Massaction design issue with sub menu #20928: [Backend] Admin product grid Massaction design issue with sub menu
  2. ...

Manual testing scenarios (*)

  1. Goto Catalog > Product grid page
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ananth-iyer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 3, 2019

CLA assistant check
All committers have signed the CLA.

@sdzhepa sdzhepa self-assigned this Feb 4, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 4, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-20938-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 4, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20938.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 4, 2019

Hello @ananth-iyer
Thank you for contribution and collaboration!

We found this PR does not fix mentioned issue but brings a new one.
Could you please have a look and fix it?

Please, see attached GIF for more details
bcbf30cb-1cae-47f5-8d54-9a3dfe8e0a05

@ananth-iyer
Copy link
Member Author

ananth-iyer commented Feb 4, 2019

@sdzhepa Oh! I will create a new PR for the fixes. Can you check in 2.3 without my PR? if you see the scroll bar in Change Status submenu

@ananth-iyer
Copy link
Member Author

@sdzhepa I have checked in Magento 2.2.x is showing correct design. I think need to check design for 2.3 only.

@ananth-iyer
Copy link
Member Author

@sdzhepa Because of this PR changes my design changes are affected, let me know my next step: #10651

@ananth-iyer ananth-iyer force-pushed the bugfix/massaction-grid-issue branch 2 times, most recently from 6e41382 to facfa44 Compare February 6, 2019 08:55
@ananth-iyer
Copy link
Member Author

@sdzhepa I have fixed the issue you mentioned in below:

Hello @ananth-iyer
Thank you for contribution and collaboration!

We found this PR does not fix mentioned issue but brings a new one.
Could you please have a look and fix it?

Please, see attached GIF for more details
bcbf30cb-1cae-47f5-8d54-9a3dfe8e0a05

New design for submenu in Massaction:
ezgif-3-ab436f3fc11c

@sdzhepa
Copy link
Contributor

sdzhepa commented Mar 1, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-20938.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa sdzhepa removed their assignment Mar 1, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @ananth-iyer, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Ctucker9233
Copy link

@magento-engcom-team is a 2.2 backport planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants