Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix syntax of expectException() calls #14621

Merged
merged 10 commits into from
Apr 17, 2018
Merged

[Forwardport] Fix syntax of expectException() calls #14621

merged 10 commits into from
Apr 17, 2018

Conversation

namlier
Copy link
Contributor

@namlier namlier commented Apr 10, 2018

Original Pull Request

#11099

(recreated #11068)

Description

RegEx search and replace from ( *)\$this->expectException\(([^\n,]+), ([^)\n]+)\); to $1\$this->expectException($2);\n$1\$this->expectExceptionMessage($3);

Fixed Issues (if relevant)

  1. 92 usages of expectException() with ignored $message parameter #11059: 92 usages of expectException() with ignored $message parameter

Manual testing scenarios

  1. Change an exception message that should be covered by a test

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

schmengler and others added 7 commits April 10, 2018 15:07
expectException(); expectExceptionMessage()
(cherry picked from commit d2e0d44)
expectException(); expectExceptionMessage()
(cherry picked from commit 485cd57)
(cherry picked from commit 3dbfc5e)
(cherry picked from commit 02a09d6)
(cherry picked from commit d81d25e)
@magento-engcom-team
Copy link
Contributor

Hi @mastiuhin-olexandr. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants