Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax of expectException() calls #11099

Merged
merged 7 commits into from
Dec 7, 2017
Merged

Fix syntax of expectException() calls #11099

merged 7 commits into from
Dec 7, 2017

Conversation

schmengler
Copy link
Contributor

@schmengler schmengler commented Sep 27, 2017

(recreated #11068)

Description

RegEx search and replace from ( *)\$this->expectException\(([^\n,]+), ([^)\n]+)\); to $1\$this->expectException($2);\n$1\$this->expectExceptionMessage($3);

Fixed Issues (if relevant)

  1. 92 usages of expectException() with ignored $message parameter #11059: 92 usages of expectException() with ignored $message parameter

Manual testing scenarios

  1. Change an exception message that should be covered by a test

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@schmengler schmengler changed the title Expect exception 2.2 Fix syntax of expectException() calls Sep 27, 2017
@vrann vrann self-assigned this Sep 27, 2017
@vrann vrann added this to the September 2017 milestone Sep 27, 2017
@vrann vrann reopened this Sep 29, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 7, 2017
@okorshenko okorshenko assigned okorshenko and unassigned vrann Nov 28, 2017
@sidolov sidolov self-assigned this Dec 5, 2017
@sidolov
Copy link
Contributor

sidolov commented Dec 5, 2017

Additionally fixed 41 file

@magento-team magento-team merged commit d81d25e into magento:2.2-develop Dec 7, 2017
magento-team pushed a commit that referenced this pull request Dec 7, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-84981: Trying to get data from non existent products #12539
 - MAGETWO-84979: [Backport 2.2-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12541
 - MAGETWO-84903: Added namespace to product videos fotorama events #12469
 - MAGETWO-84862: [Backport 2.2-develop] #11409: Too many password reset requests even when disabled in settings #11435
 - MAGETWO-84856: Issue 12506: Fixup typo getDispretionPath -> getDispersionPath #12507
 - MAGETWO-84808: 12110: Missing cascade into attribute set deletion. #12167
 - MAGETWO-83503: [2.2] - Add command to view mview state and queue #12122
 - MAGETWO-80223: Fix syntax of expectException() calls #11099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants