[Backport 2.2-develop] #11409: Too many password reset requests even when disabled in settings

[adrian-martinez-interactiv4]

When attempting to reset a customer's password via the admin, the system tells me 'Too many password reset requests' even when I have disabled the 'max wait time between password resets' in the store configuration settings.

Related with PR#11434

Description

\Magento\Security\Model\Config::getXmlPathPrefix() method fails to use the customer configuration customer/password/, using the admin/security/ settings instead, when reset password is triggered from admin, due to current scope:

    /**
     * {@inheritDoc}
     *
     * @return string
     */
    protected function getXmlPathPrefix()
    {
        if ($this->scope->getCurrentScope() == \Magento\Framework\App\Area::AREA_ADMINHTML) {
            return self::XML_PATH_ADMIN_AREA;
        }
        return self::XML_PATH_FRONTEND_AREA;
    }

Emulated frontend area in scope in plugin method \Magento\Security\Model\Plugin\AccountManagement::beforeInitiatePasswordReset, also fixed di.xml parameter injection that caused customer password reset requests also counting as admin user requests when emails coincide for admin user and customer.

Fixed Issues (if relevant)

1. Too many password reset requests even when disabled in settings #11409: Too many password reset requests even when disabled in settings

Manual testing scenarios

• Login to the admin
• Go to Customers > All Customers
• Click to edit a customer and click 'Reset Password' from the options in the top
• This works the first time, but only then. Every subsequent request fails.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[dmanners]

See #11434 (comment) for comment on change.

[dmanners]

Unfortunately we cannot rename constants even if it contained a spelling mistake before :( http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#removing-or-renaming-constants

[dmanners]

You could always deprecate the constant with the spelling mistake, create a new constant and use that. Then update the old constant to use the new one, I think that would work.

[dmanners]

As discussed it would be great to get this to include the same changes with #11434 and also to update the constants so that we do not break BC.

[dmanners]

I will put this on hold until #11434 has been merged into 2.3-develop

[dmanners]

Now that #11434 has been sorted can you make the same changes into the backported PRs @adrian-martinez-interactiv4