Issue 12506: Fixup typo getDispretionPath -> getDispersionPath #12507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if all pull requests need an issue, so I created one just to be sure. |
sidolov
requested changes
Dec 1, 2017
| @@ -611,7 +611,7 @@ public static function getNewFileName($destinationFile) | |||
| * @param string $fileName | |||
| * @return string | |||
| */ | |||
| public static function getDispretionPath($fileName) | |||
| public static function getDispersionPath($fileName) | |||
There was a problem hiding this comment.
Renaming public methods is backward incompatible.
Please, refactor this codes with following steps:
- introduce new method getDispersionPath
- move logic from old getDispretionPath method to created getDispersionPath
- mark old method as @deprecated
- make proxy call from old method to new
public static function getDispretionPath($fileName)
{
return self::getDispersionPath($fileName);
}
Backward compatible development rules described in http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/
There was a problem hiding this comment.
You're right, I was too quick. Made the necessary changes
sidolov
approved these changes
Dec 1, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 7, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 7, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-84981: Trying to get data from non existent products #12539 - MAGETWO-84979: [Backport 2.2-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12541 - MAGETWO-84903: Added namespace to product videos fotorama events #12469 - MAGETWO-84862: [Backport 2.2-develop] #11409: Too many password reset requests even when disabled in settings #11435 - MAGETWO-84856: Issue 12506: Fixup typo getDispretionPath -> getDispersionPath #12507 - MAGETWO-84808: 12110: Missing cascade into attribute set deletion. #12167 - MAGETWO-83503: [2.2] - Add command to view mview state and queue #12122 - MAGETWO-80223: Fix syntax of expectException() calls #11099
magento-engcom-team
added
Reproduced on 2.1.x
paales
added
the
Partner: Reach Digital
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixup typo getDispretionPath -> getDispersionPath
Fixed Issues (if relevant)
Contribution checklist