Add default schedule config for sitemap_generate job #14822
Conversation
magento-engcom-team
added
the
partners-contribution
|
@jameshalsall thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
jameshalsall
force-pushed
the
fix-sitemap-cron
branch
from
37ae12a
to
9463c77
Compare
jameshalsall
changed the title
| /** | ||
| * Cronjob expression configuration | ||
| */ | ||
| const XML_PATH_CRON_EXPR = 'crontab/default/jobs/generate_sitemaps/schedule/cron_expr'; |
There was a problem hiding this comment.
I would suggest to deprecate this instead of removing
There was a problem hiding this comment.
I would agree, but a) Magento does not follow semantic versioning between marketing releases and b) it points at the wrong config path so it's incredibly unlikely this is used anywhere directly.
There was a problem hiding this comment.
In any way it is better to stay on a safe side and follow conventions where possible.
|
Travis failure is unrelated. |
|
@jameshalsall Please use you own fork for to submit the Pull Request, instead of magento/magento2 |
|
Yeah I pushed to the main repository by mistake 🤦♂️ |
|
Hi @jameshalsall. Thank you for your contribution. |
Description
There was no default schedule configuration for
sitemap_generatejob, and I think this is causing confusion for some people.Also I have removed a redundant constant in the sitemap observer.
I think more work is required on sitemaps following this.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist