Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Add default schedule config for sitemap_generate job #14908

Conversation

rostyslav-hymon
Copy link
Contributor

Original Pull Request

#14822

Description

There was no default schedule configuration for sitemap_generate job, and I think this is causing confusion for some people.

Also I have removed a redundant constant in the sitemap observer.

I think more work is required on sitemaps following this.

Fixed Issues (if relevant)

  1. Magento 2.0.7 XML sitemap is not generated by schedule #5768: Magento 2.0.7 XML sitemap is not generated by schedule (potentially, waiting feedback from creator)

Manual testing scenarios

  1. Create sitemap via admin
  2. Do not sitemap generation schedule settings in Store > Configuration > Catalog > XML Sitemap > Generation Settings
  3. Configure magento cron
  4. Sitemap should be updated at midnight.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @rostyslav-hymon. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants