Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOBISSUE date format changed after customer tries to register with sa… #15272

Merged
merged 7 commits into from
Jun 18, 2018

Conversation

KaushikChavda
Copy link
Contributor

@KaushikChavda KaushikChavda commented May 17, 2018

Description

When DOB is enabled on the registration page and existing customer tries to re-registration page, DOB format was changed. See the screenshot.
image

Manual testing scenarios

  1. Tested in my local environment and fixed issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1625 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented May 22, 2018

Hi @KaushikChavda , during QA activities we found issue with provided implementation, please, take a look:

Steps to reproduce:

  • Enable DOB: Stores->Configuration->Customers->Customer Configuration->Show Date of Birth=Optional
  • Create new customer with DOB.
  • Go to My Account->Account Information.

Expected result:
Correct DOB format

Actual result:
Incorrect DOB format.

15272brokendob

@KaushikChavda
Copy link
Contributor Author

@sidolov Could you please provide me the magento version.

@sidolov
Copy link
Contributor

sidolov commented May 22, 2018

@KaushikChavda sure, latest 2.2-develop

@KaushikChavda
Copy link
Contributor Author

@sidolov I've fixed the issue.

@sidolov
Copy link
Contributor

sidolov commented Jun 8, 2018

Hi @KaushikChavda , we found new issue with current solution:

On Create New Customer Account page DOB field always contains default date "1/1/1970" instead of empty field.

Steps to reproduce:

Enable DOB: Stores->Configuration->Customers->Customer Configuration->Show Date of Birth=Optional(or Required)
Go to Create New Customer Account page

Expected result:
Empty DOB field

Actual result:
DOB field contains default date "1/1/1970".

@KaushikChavda
Copy link
Contributor Author

@sidolov,

I've tested on latest Magento branch 2.2.6 and latest 2.2-develop its working fine.

@miguelbalparda
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, here is your Magento instance.
Admin access: https://pr-15272.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@miguelbalparda
Copy link
Contributor

I was able to reproduce @sidolov issue in the test environment.

@magento-engcom-team
Copy link
Contributor

Hi @KaushikChavda. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants