Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] DOBISSUE date format changed after customer tries to register with sa… #15754

Conversation

viral-wagento
Copy link
Contributor

@viral-wagento viral-wagento commented Jun 4, 2018

Original Pull Request

#15272

Description

When DOB is enabled on the registration page and existing customer tries to re-registration page, DOB format was changed. See the screenshot.
image

Manual testing scenarios

  1. Tested in my local environment and fixed issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov added partners-contribution Pull Request is created by Magento Partner Partner: Wagento Pull Request is created by partner Wagento labels Jun 6, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 19, 2018

@viral-wagento , original pull request has a different solution, please, update current PR with latest fixes from the original.

@sidolov
Copy link
Contributor

sidolov commented Jul 16, 2018

Hi @viral-wagento , this PR does not fix the problem described in issue.

Steps to reproduce:

  1. Set Show Date of Birth=Optional
  2. Try to create the customer with an email that belongs to other registered customers.
  3. Fiil Date of Birth field.
  4. Click Create an Account.

Result:
Incorrect format of date in Date of Birth field
15754

@sidolov
Copy link
Contributor

sidolov commented Jul 30, 2018

@viral-wagento , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants