Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Refactored javascript code of admin notification modal popup #15442

Closed
wants to merge 14 commits into from
Closed

[Backport] Refactored javascript code of admin notification modal popup #15442

wants to merge 14 commits into from

Conversation

RahulKachhadia
Copy link
Member

Original Pull Request

#15341

Description

  • Refactored javascript code from popup.phtml according to Magento way.
  • Created a JS component file js/system/messages/popup.js

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio self-assigned this May 23, 2018
@osrecio
Copy link
Member

osrecio commented May 25, 2018

Hi @rahul-kachhadiya , I'm working to process this PR. Thanks for your contribution.

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone May 25, 2018
RahulKachhadia and others added 10 commits June 5, 2018 12:22
@RahulKachhadia
Merge pull request #4 from rahul-kachhadiya/2.1-develop-PR-port-15269
f929dfe 
[Backport] Fix typo in Image::open exception message
@KaushikChavda @RahulKachhadia
ISSUE-14747 Newsletter subscription confirmation message does not dis…
1839f97 
…play after clicking link in email
@RahulKachhadia
Merge pull request #6 from rahul-kachhadiya/2.1-develop-PR-port-15247
5064ab4 
[Backport] ISSUE-14747 Newsletter subscription confirmation message does not dis…
@jissereitsma @RahulKachhadia
Move buttons definition to separate file
c95eedc
@jissereitsma @RahulKachhadia
Change relative path to absolute path for testability
2e5538e
@jissereitsma @RahulKachhadia
Add strict mode
e4eb4ed
@jissereitsma @RahulKachhadia
Fix missing comma
7a49c89
@jissereitsma @RahulKachhadia
Make sure colons are in right place
a30611d
@jissereitsma @RahulKachhadia
Fix missing column because of eslint
0852240
@RahulKachhadia
Merge pull request #7 from rahul-kachhadiya/2.1-develop-PR-port-15194
12b4ff4 
[Backport] Move buttons definition to separate file
@RahulKachhadia RahulKachhadia deleted the 2.1-develop branch June 5, 2018 18:15
@RahulKachhadia RahulKachhadia restored the 2.1-develop branch June 5, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@osrecio osrecio

Labels
Component: AdminNotification Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
6 participants
@RahulKachhadia @osrecio @magento-engcom-team @gelanivishal @KaushikChavda @jissereitsma