Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport placeholder image #15890

Closed
wants to merge 16 commits into from
Closed

Backport placeholder image #15890

wants to merge 16 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Product placeholder image resize issue #13636: Product placeholder image resize issue

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 16 commits June 4, 2018 10:34
@chirag-wagento
Product placeholder image resize issue #13636
acf52ec
@chirag-wagento
Merge pull request #1 from chirag-wagento/2.1-develop-PR-port-15758
e7fc759 
[Backport] Product placeholder image resize issue #13636
@chirag-wagento
Removed unnecessary css.
8bacebe
@chirag-wagento
Merge pull request #3 from chirag-wagento/2.1-develop-PR-port-15789
0b5167e 
[Backport] Removed unnecessary css.
@chirag-wagento
Merge pull request #5 from chirag-wagento/2.1-develop-PR-port-15790
682a932 
[Backport] Make necessary space.
@chirag-wagento
Removed unused class from forms less file.
3c88933
@chirag-wagento
Merge pull request #7 from chirag-wagento/2.1-develop-PR-port-15791
72d8d08 
[Backport] Removed unused class from forms less file.
@lewisvoncken @chirag-wagento
Added row_id to the flat action indexer so the value isn't set to 0 f…
c080b15 
…or new products when using index on save
@lewisvoncken @chirag-wagento
Moved the indexAll after the product save in the Indexer Product Flat…
ac0e159 
… RowTest
@chirag-wagento
Merge pull request #9 from chirag-wagento/2.1-develop-PR-port-15010
515dbae 
[Backport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
@seruymt @chirag-wagento
fix tets fixture and mark return processor as @api
24cea81
@chirag-wagento
Merge pull request #12 from chirag-wagento/2.1-develop-PR-port-14842
a21c213 
[Backport] For MSI-377: fix test fixture and mark return processor as @api
@phoenix128 @chirag-wagento
Fix for issue 911 found on MSI project - Cannot read property source_…
68e19af 
…code of undefined Dynamic data rows were failing due to a read after delete condition Rows were removed just before the information update. An undefined javascript error was triggered.
@chirag-wagento
Merge pull request #15 from chirag-wagento/2.1-develop-PR-port-14805
10fd645 
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
@chirag-wagento
Merge remote-tracking branch 'upstream/2.1-develop' into 2.1-develop
391eb00
@chirag-wagento
Backport placeholder image issue.
9f549a3
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 6, 2018
@chirag-wagento
Copy link
Contributor Author

@VladimirZaets Could you please check what cause failed travis?

Thanks,

@VladimirZaets
Copy link
Contributor

VladimirZaets commented Jun 12, 2018 •
edited
Loading

Hi, @chirag-wagento, please fix failed unit and integration tests. Thanks

@VladimirZaets VladimirZaets mentioned this pull request Jun 12, 2018
Closed
4 tasks
@orlangur orlangur self-assigned this Jun 14, 2018
@orlangur
Copy link
Contributor

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Area: Frontend Area: Lib/Frontend Component: Catalog Component: SalesInventory Component: Ui Component: Wishlist Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
7 participants
@chirag-wagento @VladimirZaets @orlangur @magento-engcom-team @lewisvoncken @seruymt @phoenix128