Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport footer responsive #15889

Closed
wants to merge 32 commits into from
Closed

Backport footer responsive #15889

wants to merge 32 commits into from

Conversation

chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jun 6, 2018

Original Pull Request

#15353
Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 14 commits June 4, 2018 10:34
[Backport] Product placeholder image resize issue #13636
[Backport] Removed unused class from forms less file.
[Backport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
[Backport] For MSI-377: fix test fixture and mark return processor as @api
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
ankurvr and others added 11 commits June 10, 2018 03:56
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660
[Backport] Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies
[Backport] Small refactoring to better code readability
[Backport] bugfix checkout page cart icon color
[Backport] fix for dropdown toggle icon in cart
@VladimirZaets
Copy link
Contributor

Hi @chirag-wagento. This PR looks the same as the PR 15890. I closed this one and will process 15890

@chirag-wagento
Copy link
Contributor Author

@VladimirZaets Can you please check both PR are different you can see ticket title.

@VladimirZaets
Copy link
Contributor

@chirag-wagento As I see the changes comparing with 15890 are only in one file (app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less). Please commit this changes to PR 15890 or apply the fix to wishlist (app/code/Magento/Wishlist/CustomerData/Wishlist.php) from PR 15890 to this.

@chirag-wagento
Copy link
Contributor Author

chirag-wagento commented Jun 12, 2018

@VladimirZaets There are both different issue ticket so i was do work with different branch you can check issue ticket.

You can see below URL both tickets issue is different.
#15118
OR
#13636

@VladimirZaets
Copy link
Contributor

The changes of code in this two 2 PRs different only in one file. I understand this PRs fixed two different issue. Please, merge they're to one PR and add the description of all issues fixed in the PR.
We will add additional rewards (for all issues that will be fixed) when PR will be merged.

@orlangur
Copy link
Contributor

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants