-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118
Comments
Would this be related to the issue I've seen when scrolling to the bottom of a page on mobile and it snaps your view back up midpage? |
I am working on this at #dmcdindia |
Hi @gwharton. Thank you for your report. The fix will be available with the upcoming 2.2.5 release. |
I don't agree with the resolution of this issue to be honest. Placing both footer and copyright at position absolute, bottom: 0 means that the footer is partially obscured by the copyright. It also means that pages that have content larger than one page, the footer stays on screen and the content disappears down behind the footer. I would have though the best implementation would be to use the same method as the desktop layout and instead of the implemented changes, you would have something like this instead, to make the page full height, and grow the main content panel, effectively pushing the footer and copyright sections to the bottom.
|
@gwharton, Thanks for review my code. Thanks |
Updated PR #15471 working perfectly for me. Thanks @chirag-wagento |
[Forwardport] Responsive Design Footers bottom of screen on mobile devices magento#15118
[Backport] Responsive Design Footers bottom of screen on mobile devices magento#15118
@gwharton, thank you for your report. |
Hi @gwharton. Thank you for your report. The fix will be available with the upcoming 2.3.0 release. |
Just to confirm. This isnt fixed. The resolution applied to 2.2 and 2.3 is not a good one and needs relooking at. |
Hi @denistrator , I guess your PR #17006 contains fix for this issue and currently in status |
Hi @gwharton. Thank you for your report. The fix will be available with the upcoming 2.2.6 release. |
Fix PR #17006 working well for me. |
Hi @gwharton. Thank you for your report. The fix will be available with the upcoming 2.3.0 release. |
When you view Magento pages on a mobile device, the footers do not snap to the bottom of the page. They do in tablet and desktop modes.
Preconditions
Steps to reproduce
Expected result
Actual result
Here is a video
https://www.youtube.com/watch?v=pYe7uocqkTw
The text was updated successfully, but these errors were encountered: