Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forwordport responsive footer #15885

Closed
wants to merge 16 commits into from
Closed

Forwordport responsive footer #15885

wants to merge 16 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15353
Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 16 commits June 5, 2018 04:19
@chirag-wagento
Removed unnecessary css.
cd0a7b4
@chirag-wagento
Merge pull request #2 from chirag-wagento/2.3-develop-PR-port-15789
a7de37c 
[Forwardport] Removed unnecessary css.
@chirag-wagento
Make necessary space.
ed9b567
@chirag-wagento
Merge pull request #4 from chirag-wagento/2.3-develop-PR-port-15790
ffa4a1a 
[Forwardport] Make necessary space.
@chirag-wagento
Removed unused class from forms less file.
3a2bda2
@chirag-wagento
Merge pull request #6 from chirag-wagento/2.3-develop-PR-port-15791
a12ce0e 
[Forwardport] Removed unused class from forms less file.
@lewisvoncken @chirag-wagento
Added row_id to the flat action indexer so the value isn't set to 0 f…
2445b74 
…or new products when using index on save
@lewisvoncken @chirag-wagento
Moved the indexAll after the product save in the Indexer Product Flat…
58f4a48 
… RowTest
@chirag-wagento
Merge pull request #8 from chirag-wagento/2.3-develop-PR-port-15010
73acff7 
[Forwardport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
@chirag-wagento
Merge pull request #10 from chirag-wagento/2.3-develop-PR-port-14967
3b8cc19 
[Forwardport] Format the javascript code
@sanganinamrata @chirag-wagento
Fixed set template syntax issue
444fce2
@chirag-wagento
Merge pull request #16 from chirag-wagento/2.3-develop-PR-port-15825
035363e 
[Forwardport] Fixed set template syntax issue
@chirag-wagento
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
c03e53b
@chirag-wagento
Frontport responsive footer issue.
e813739
@chirag-wagento
Frontport footer responsive issue
75932ad
@chirag-wagento
Frontport solve footer responsive issue.
32264ee
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 6, 2018
@chirag-wagento
Copy link
Contributor Author

@VladimirZaets Could you please check what cause failed travis?

Thanks,

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop June 13, 2018 11:59
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop June 13, 2018 12:00
@orlangur orlangur self-assigned this Jun 14, 2018
@orlangur
Copy link
Contributor

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orlangur orlangur

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Area: Frontend Area: Lib/Frontend Component: Bundle Component: Catalog Component: Ui Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@chirag-wagento @orlangur @VladimirZaets @magento-engcom-team @lewisvoncken @sanganinamrata