Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve incorrect scope code selection when the requested scopeCode is null #16940

Merged
merged 3 commits into from
Oct 25, 2018
Merged

Resolve incorrect scope code selection when the requested scopeCode is null #16940

merged 3 commits into from
Oct 25, 2018

Commits on Jul 19, 2018

  1. Resolve incorrect scope code selection when the requested scopeCode i… 

    …s null

- resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null
- simplify the scope resolver logic to a avoid multiple if conditional checks
- move scope interface class to an alias of the class
- update docblock on the expected values available for scopeCode

Signed-off-by: Matthew Muscat <matthew@mamis.com.au>
    @matthew-muscat
    matthew-muscat committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    d79cfa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. update travis-ci for phpcs static test

    @matthew-muscat
    matthew-muscat authored Jul 20, 2018
    Configuration menu
    Copy the full SHA
    a9c4838 View commit details
    Browse the repository at this point in the history

  2. Update null conditional check

    @matthew-muscat
    matthew-muscat authored Jul 20, 2018
    Configuration menu
    Copy the full SHA
    93edb38 View commit details
    Browse the repository at this point in the history