Resolve incorrect scope code selection when the requested scopeCode is null #16940
Conversation
…s null - resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null - simplify the scope resolver logic to a avoid multiple if conditional checks - move scope interface class to an alias of the class - update docblock on the expected values available for scopeCode Signed-off-by: Matthew Muscat <matthew@mamis.com.au>
|
|
|
Hi @matthew-muscat. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
FYI - Codacy PR quality review is stating the else condition is not required - however this was present prior to my pull request. |
| $resolverScopeCode = $resolverScopeCode->getCode(); | ||
| } | ||
|
|
||
| if ($scopeCode == null) { |
There was a problem hiding this comment.
I suggest changing this statement according to the general rule of preferring the identical comparison operator === over the equal one ==.
There was a problem hiding this comment.
Thanks @aleron75 — confirming this has been done
|
Hi @aleron75, thank you for the review. |
|
@matthew-muscat thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
…d scopeCode is null #16940
…d scopeCode is null #16940
|
Hi @matthew-muscat. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Resolves #16939
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist