Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Resolve incorrect scope code selection when the requested scopeCode is null #21633

Merged

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#16940

Description

  • resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null
  • simplify the scope resolver logic to a avoid multiple if conditional checks
  • move scope interface class to an alias of the class
  • update docblock on the expected values available for scopeCode

Resolves #16939

Fixed Issues (if relevant)

  1. Incorrect configuration scope is occasionally returned when attempting to resolve a null scope id #16939: Incorrect configuration scope is occasionally returned when attempting to resolve a null scope id

Manual testing scenarios

  1. See Incorrect configuration scope is occasionally returned when attempting to resolve a null scope id #16939 for steps to repeat issue + confirm issue is not present when these changes are active

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…s null

- resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null
- simplify the scope resolver logic to a avoid multiple if conditional checks
- move scope interface class to an alias of the class
- update docblock on the expected values available for scopeCode

Signed-off-by: Matthew Muscat <matthew@mamis.com.au>
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned rogyar Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4458 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 29, 2019
@mage2pratik mage2pratik deleted the 2.3-develop-PR-port-16940 branch March 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect configuration scope is occasionally returned when attempting to resolve a null scope id
6 participants