Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Resolve incorrect scope code selection when the requested scopeCode is null #21633

Merged
merged 4 commits into from
Apr 29, 2019
Merged

[Forwardport] Resolve incorrect scope code selection when the requested scopeCode is null #21633

merged 4 commits into from
Apr 29, 2019

Commits on Mar 7, 2019

  1. Resolve incorrect scope code selection when the requested scopeCode i… 

    …s null

- resolves an issue whereby the incorrect scope could be returned when attempting to resolve a scope with a requested scopeCode of null
- simplify the scope resolver logic to a avoid multiple if conditional checks
- move scope interface class to an alias of the class
- update docblock on the expected values available for scopeCode

Signed-off-by: Matthew Muscat <matthew@mamis.com.au>
    @matthew-muscat @mage2pratik
    matthew-muscat authored and mage2pratik committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    bc8f909 View commit details
    Browse the repository at this point in the history

  2. update travis-ci for phpcs static test

    @matthew-muscat @mage2pratik
    matthew-muscat authored and mage2pratik committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    ca16809 View commit details
    Browse the repository at this point in the history

  3. Update null conditional check

    @matthew-muscat @mage2pratik
    matthew-muscat authored and mage2pratik committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    9e5fdbb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Merge branch '2.3-develop-mainjline' into 2.3-develop-PR-port-16940

    @p-bystritsky
    p-bystritsky committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    e2ce243 View commit details
    Browse the repository at this point in the history