Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-validation-new-from-date-less-than-new-to-date-in-SCV-product-import #19024

Conversation

agorbulin
Copy link

add validation for fields new_from_date and new_to_date
to make sure field new_from_date < new_to_date during CSV product import
to prevent future error 'Make sure the To Date is later than or the same as the From Date.' during saving updated product in BO

Description ()

Added validation during CSV product import:
new_from_date field must be <= than new_to_date field,
because the same validation performed during product saving in BO

Fixed Issues ()

It's fix for the ticket
https://support.magento.com/hc/en-us/requests/105483

Manual testing scenarios (*)

  • export some product by CSV export, open CSV for edit
  • set field new_from_date = 11/3/20
  • set field new_to_date = 11/3/19 (less than previous)
  • import CSV
  • see validation error: 'Make sure new_to_date is later than or the same as new_from_date'

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

add validation for fields new_from_date and new_to_date
to make sure field new_from_date < new_to_date
to prevent future errors during saving updated product
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: CatalogImportExport labels Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3406 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

agorbulin pushed a commit to agorbulin/magento2 that referenced this pull request Nov 24, 2018
Back-port magento#19024 from 2.3 to 2.2
@agorbulin agorbulin mentioned this pull request Nov 24, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants