Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back-port-pull-19024 #19374

Merged

Conversation

agorbulin
Copy link

Back-port #19024 from 2.3 to 2.2

Description (*)

Fixed Issues (if relevant)

It's fix for the ticket
https://support.magento.com/hc/en-us/requests/105483

Manual testing scenarios (*)

export some product by CSV export, open CSV for edit
set field new_from_date = 11/3/20
set field new_to_date = 11/3/19 (less than previous)
import CSV
see validation error: 'Make sure new_to_date is later than or the same as new_from_date'

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Back-port magento#19024 from 2.3 to 2.2
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: CatalogImportExport labels Nov 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rodrigowebjump
Copy link
Member

Hi @agorbulin Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3553 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit ce701af into magento:2.2-develop Nov 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogImportExport Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants