[2.3] Made logo clickable on home page

[gwharton]

Description (*)

Removed checks that prevent the logo being clickable on the home page. It is now clickable on all pages, including the home page (essentially refreshes the homepage)

Fixed Issues (if relevant)

1. Home page store loge should be clickable to reload page #19142: Home page store loge should be clickable to reload page

Manual testing scenarios (*)

1. Go to home page, click logo, does page reload?
2. Go to any other page, click logo, does homepage load.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[gwharton]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @gwharton. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @gwharton, here is your new Magento instance.
Admin access: http://34.228.235.121/pr-19198//admin
Login: admin Password: 123123q

[gwharton]

I can confirm changes work as planned on test instance.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3669 has been created to process this Pull Request

[orlangur]

@gwharton it looks like after this change \Magento\Theme\Block\Html\Header\Logo::isHomePage method is not used anymore, please deprecate it mentioning this so that it can be later removed.

Changes incorporated

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3669 has been created to process this Pull Request

[magento-engcom-team]

Hi @gwharton. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.